Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance Windows] Skip module upgrades during maintenance window #2101

Open
7 tasks
lindnerby opened this issue Dec 9, 2024 · 3 comments · Fixed by #2179, #2196, #2200 or #2201 · May be fixed by #2206
Open
7 tasks

[Maintenance Windows] Skip module upgrades during maintenance window #2101

lindnerby opened this issue Dec 9, 2024 · 3 comments · Fixed by #2179, #2196, #2200 or #2201 · May be fixed by #2206
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@lindnerby
Copy link
Member

lindnerby commented Dec 9, 2024

Depends on: #2163

Once KLM can read maintenance window policies and have them cached, it needs to respect these for modules requiring downtime. Overall, the following cases need to be covered:

  • Module.RequiresDowntime: FALSE, Kyma.UseMaintenanceWindows: FALSE => module updated immediately
  • Module.RequiresDowntime: TRUE, Kyma.UseMaintenanceWindows: FALSE => module updated immediately
  • Module.RequiresDowntime: TRUE, Kyma.UseMaintenanceWindows: TRUE => module updated within next window, in the meantime reconciled in its currently installed version
  • Module.RequiresDowntime: FALSE, Kyma.UseMaintenanceWindows: TRUE => module updated immediately

AC

Related issue

@lindnerby lindnerby added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 9, 2024
@c-pius

This comment was marked as resolved.

@c-pius

This comment has been minimized.

@c-pius c-pius self-assigned this Jan 15, 2025
@nesmabadr
Copy link
Contributor

For the E2E test, we can add the maintenance windows component to the watcher_local_test Kustomization profile by using the command kustomize edit add component ../maintenance_windows from the watcher_local_test path in the workflow

@c-pius c-pius linked a pull request Jan 16, 2025 that will close this issue
@c-pius c-pius reopened this Jan 20, 2025
@c-pius c-pius linked a pull request Jan 20, 2025 that will close this issue
@janmedrek janmedrek reopened this Jan 21, 2025
@c-pius c-pius linked a pull request Jan 22, 2025 that will close this issue
@c-pius c-pius linked a pull request Jan 23, 2025 that will close this issue
@c-pius c-pius reopened this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment