Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add version and name helpers to ModuleTemplate #2201

Merged
merged 3 commits into from
Jan 23, 2025
Merged

chore: Add version and name helpers to ModuleTemplate #2201

merged 3 commits into from
Jan 23, 2025
+147 −41

Conversation

c-pius
Copy link
Contributor

@c-pius c-pius commented Jan 23, 2025 •
edited
Loading

Description

Changes proposed in this pull request:

  • Adds another set of helpers to the ModuleTemplate type for getting version and name
  • Background: make it more robust when handling different gerneations of ModuleTempalte (old ones, new ones)
    • e.g., in the maintenance window logic

Related issue(s)

@c-pius c-pius requested a review from a team as a code owner January 23, 2025 09:33
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 23, 2025
@c-pius c-pius linked an issue Jan 23, 2025 that may be closed by this pull request
[Maintenance Windows] Skip module upgrades during maintenance window #2101
Open
7 tasks
@LeelaChacha LeelaChacha self-assigned this Jan 23, 2025
LeelaChacha
LeelaChacha approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@LeelaChacha LeelaChacha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 23, 2025
@c-pius c-pius merged commit f025813 into kyma-project:main Jan 23, 2025
68 of 69 checks passed
@c-pius c-pius deleted the chore/name-version-helpers branch January 23, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LeelaChacha LeelaChacha LeelaChacha approved these changes

Assignees

@LeelaChacha LeelaChacha

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maintenance Windows] Skip module upgrades during maintenance window
3 participants
@c-pius @LeelaChacha @kyma-bot