Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Updates and Bug Fixes #264

Draft
wants to merge 154 commits into
base: master
Choose a base branch
from
Draft

Conversation

ethanaobrien
Copy link

@ethanaobrien ethanaobrien commented Apr 13, 2021

Resolves #262 - (Adds option to show a 404 error instead of rendering the directory listing)
Resolves #203 - You can click the name button to flip the order. - Is not sorted alphabetically on load.
Resolves #261 - I just had to change react and react-dom to version 17.0.2 - The ui seems to work faster now tbh.
Resolves #266 - When https option changes, the web server shuts down, and turns back on. Using callbacks to prevent race conditions
Resolves #135 - I added the code that @er2er Commented with. Also added delete option under upload option
Resolves #182 - Added support for custom 404, 403, 401, and 400 pages. (Also added failsafe for when user put in wrong path of html file), also, I added a feature that will send the client a script element so that the author of the site can customize the page. (Only 404) Its hard to explain, just take a look. (If I were you and If I could word it better I would change the name of the option in options.js)
Resolves #263 - Fixed incorrect displayed protocol
Resolves #267 - Will only create background window if web server is turned on
Possibly Resolves #258 - will look for index.html file without case sensitivity
Resolves #269 - Rewrite options and 404 options render as the https options do.
Resolves #186 - Option to omit .html extension from user request path (Not the file itself). When this option is enabled and a file ending in .html is called, the browser will re-direct the file (Using 307 so the browser does not cache) to use not the html extension.
Resolves #177 - Added gz file type to mime.js
Resolves #191 (This was VERY difficult) - Added support for wsc.htaccess. It is similar to .htaccess. Not fully implemented. The problem in #191 is technically resolved above More details can be found here. Note: In /react-ui/js/index.js the instructions on how to use a wsc.htaccess file would have been too big so I put a message when feature enabled saying "For more info on how to use wsc.htaccess files, go here" and the text "Here" has a link to here. You might want to replace that link to the htaccess readme in your repository (or we could copy it into the wiki). If the wsc.htaccess file is not a valid json file, there is a failsafe.
Resolves #42 - Add date modified and size to directory listing. Performance does not suffer.
Resolves #130 - Add cache-control header option in advanced settings.
Resolves #274 - Fixed
Resolves #276 - Created a customizable server side post handler
Resolves #45 - Option to log to a file
Resolves #299 - adds post handler

Since Kyle seems inactive on github, you can download the zip archive below, go to chrome://extensions, turn on developer mode, and click "load unpacked" and select the directory that contains the extracted zip file

Tested by me.
I changed the version in the manifest to 2.5.3, you can change it if you like. (I think it should be higher with the amount of features added)

I also just replaced the broken image in the readme with the default logo in the readme

If you dont like the message it gives when there is no index.html, you can easily change it in the handlers.js file

Also, I dont know if it is just me, but when packing the app I had to add npm install after the cd ../react-ui step.

Zip archive of compiled app (I try to keep this up to date): https://drive.google.com/file/d/12Ewzalvx5ZMdleWcGnms4XFnHWC4j65_/view?usp=sharing

I would recommend that you re-compile the app on your end. The zip is just for testing

I also changed the Index of current directory message to the path of the user

(When Fixing Fix #266 I accidentally marked the contribute as #226)

@kzahel #266 needs to be fixed asap - This bug causes https to only work on chromebook without constantly restarting google chrome

@ethanaobrien ethanaobrien changed the title Add support for 404 instead of dir listing Add support for 404 instead of dir listing + a few other things Apr 27, 2021
@ethanaobrien ethanaobrien changed the title Add support for 404 instead of dir listing + a few other things Feature Update and Bug Fixes Apr 29, 2021
@ethanaobrien ethanaobrien changed the title Feature Update and Bug Fixes Feature Updates and Bug Fixes Apr 29, 2021
@ethanaobrien
Copy link
Author

@kzahel Because of this. I will no longer be working on this. You can merge this when you are ready!

Copy link

@dpm2682 dpm2682 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@ethanaobrien ethanaobrien requested a review from kzahel August 13, 2021 19:49
@ethanaobrien
Copy link
Author

@kzahel Do you think you could look into merging this?

@ethanaobrien
Copy link
Author

Marked as draft since I don't entirely think this should be merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment