Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General clean-up, especially around docs, in preparation for v1.0 #386

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

ceriottm
Copy link
Contributor

@ceriottm ceriottm commented Nov 3, 2024

Mildly customized furo theme looks much better IMO

When shapes got selected, it was not possible to go back to a
visualization without shapes by just crtl-clicking all entries
in the shape list. Had do move around some stuff making the code
a bit less transparent.
@ceriottm ceriottm requested a review from Luthaf November 6, 2024 18:55
@ceriottm
Copy link
Contributor Author

ceriottm commented Nov 6, 2024

Fixed a couple of papercut bugs, and revamped the docs appearance. @Luthaf - IDK what you had in mind in terms of docs restructuring, overall it doesn't look bad to me as it is now.

@ceriottm
Copy link
Contributor Author

OK I tried also to look into the symbol bugs that @bernstei pointed at, but it looks like it's not a trivial fix so probably deserving of a separate PR. Time to merge this before it becomes an everything-pr!

@sofiia-chorna
Copy link
Collaborator

Thanks a lot for the clean up and update of the doc style! :)

I pushed a commit to fix a warning ignored unknown settings '{"size":{"reverse":true}}' that started to appear in some examples, like Dielectric Response.

@ceriottm
Copy link
Contributor Author

Thanks a lot for the clean up and update of the doc style! :)

I pushed a commit to fix a warning ignored unknown settings '{"size":{"reverse":true}}' that started to appear in some examples, like Dielectric Response.

Thanks - we actually removed this setting in a previous PR as it was pretty useless and complicating a lot the logic around size scaling. This error should actually be also already fixed as I modified the example .json - if you still get the error locally you probably need to clear your examples cache so they get downloaded again.

src/map/options.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants