-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General clean-up, especially around docs, in preparation for v1.0 #386
Open
ceriottm
wants to merge
15
commits into
main
Choose a base branch
from
tweak-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b90bc07
Start restructuring and restyling the docs.
ceriottm a568146
random example on the homepage
ceriottm a396348
Fixed explore model to work with mta 0.6
ceriottm dcb7fd2
Fixed de-selecting shapes
ceriottm 21ddf7a
Fixed nasty problem with z axis range set to null
ceriottm 2480c34
Stray console.log
ceriottm 4a90bcd
Fix bug with shape resetting on structure change
ceriottm c5a6e84
Update to latest 3dmol
ceriottm 81b5469
prettier
ceriottm c3926dc
Set size.reserve to false by default in map options
sofiia-chorna 0899792
Reverting size.reverse option
sofiia-chorna a10c8c5
Add model-exported.pt to gitignore
Luthaf d34a22c
Make sure to lint the JS/TS code used in jupyter
Luthaf f5c0c26
Merge branch 'main' into tweak-docs
ceriottm 924b07f
Update docs/requirements.txt
ceriottm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm worried this might make loading the website slower, since some of the examples add a fairly large download.
Zeolites.json.gz
is 1.8MiB, andCSD-1000R.json.gz
is 3.5 MiBThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, but
chemiscope.min.js
is 3MB already so even in the worst case it will make loading 2x slower....Maybe we can test a bit and see if it's a problem, and in case I think the "right thing" would be to reduce a bit the size of the demo datasets.