fix: blank /change-password page
#2596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
yomybaby
changed the title
appBody/change-password page
why-arong
reviewed
Aug 1, 2024
| @@ -157,7 +157,6 @@ export default class BackendAiEduApplauncher extends BackendAIPage { | |||
| async _initClient(apiEndpoint: string) { | |||
| this.notification = globalThis.lablupNotification; | |||
| const webUIShell: any = document.querySelector('#webui-shell'); | |||
| // webUIShell.appBody.style.visibility = 'visible'; | |||
There was a problem hiding this comment.
You deleted everything else, but why did you just annotate this line instead of erasing it? Did you leave it because it might be needed later?
There was a problem hiding this comment.
It looks like the code was cleared, not annotated out.
why-arong
approved these changes
Aug 1, 2024
ironAiken2
approved these changes
Aug 6, 2024
| @@ -157,7 +157,6 @@ export default class BackendAiEduApplauncher extends BackendAIPage { | |||
| async _initClient(apiEndpoint: string) { | |||
| this.notification = globalThis.lablupNotification; | |||
| const webUIShell: any = document.querySelector('#webui-shell'); | |||
| // webUIShell.appBody.style.visibility = 'visible'; | |||
There was a problem hiding this comment.
It looks like the code was cleared, not annotated out.
Merge activity
|
### TL;DR This PR fixed blank `/chage-password` page  Removed lines of code related to setting the visibility of `appBody` in various components. `appBody` has been deleted in #2350 ### What changed? - In `backend-ai-change-forgot-password-view.ts`, removed code setting `this.webUIShell.appBody.style.visibility`. - In `backend-ai-edu-applauncher.ts`, removed the commented-out code for setting `webUIShell.appBody.style.visibility`. - In `backend-ai-email-verification-view.ts`, removed code setting `this.webUIShell.appBody.style.visibility`. - In `backend-ai-console.d.ts`, removed the declaration of `appBody`. ### How to test? 1. Access `/change-password?token=sometoken` page. 2. If you want to get the link, you can use `cloud.backend.ai` ### Why make this change? The visibility setting of `appBody` was redundant and possibly causing issues with page rendering.
ironAiken2
force-pushed
the
fix/remove-appbody
branch
from
4be8ba8
to
38f9106
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This PR fixed blank
/chage-passwordpageRemoved lines of code related to setting the visibility of
appBodyin various components.appBodyhas been deleted in #2350What changed?
backend-ai-change-forgot-password-view.ts, removed code settingthis.webUIShell.appBody.style.visibility.backend-ai-edu-applauncher.ts, removed the commented-out code for settingwebUIShell.appBody.style.visibility.backend-ai-email-verification-view.ts, removed code settingthis.webUIShell.appBody.style.visibility.backend-ai-console.d.ts, removed the declaration ofappBody.How to test?
/change-password?token=sometokenpage.cloud.backend.aiWhy make this change?
The visibility setting of
appBodywas redundant and possibly causing issues with page rendering.