Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: blank /change-password page #2596

Merged
merged 1 commit into from
Aug 6, 2024
Merged

fix: blank /change-password page #2596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/backend-ai-change-forgot-password-view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,6 @@ export default class BackendAIChangeForgotPasswordView extends BackendAIPage {
*/
_initClient(apiEndpoint: string) {
this.webUIShell = document.querySelector('#webui-shell');
this.webUIShell.appBody.style.visibility = 'visible';
this.notification = globalThis.lablupNotification;
this.passwordChangeDialog = this.shadowRoot?.querySelector(
'#update-password-dialog',
Expand Down
1 change: 0 additions & 1 deletion src/components/backend-ai-edu-applauncher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,6 @@ export default class BackendAiEduApplauncher extends BackendAIPage {
async _initClient(apiEndpoint: string) {
this.notification = globalThis.lablupNotification;
const webUIShell: any = document.querySelector('#webui-shell');
// webUIShell.appBody.style.visibility = 'visible';
Copy link

@why-arong why-arong Aug 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You deleted everything else, but why did you just annotate this line instead of erasing it? Did you leave it because it might be needed later?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the code was cleared, not annotated out.

if (apiEndpoint === '') {
const api_endpoint: any = localStorage.getItem(
'backendaiwebui.api_endpoint',
Expand Down
1 change: 0 additions & 1 deletion src/components/backend-ai-email-verification-view.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,6 @@ export default class BackendAIEmailVerificationView extends BackendAIPage {
*/
_initClient(apiEndpoint: string) {
this.webUIShell = document.querySelector('#webui-shell');
this.webUIShell.appBody.style.visibility = 'visible';
this.notification = globalThis.lablupNotification;
this.successDialog = this.shadowRoot?.querySelector(
'#verification-success-dialog',
Expand Down
1 change: 0 additions & 1 deletion src/types/backend-ai-console.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ export default class BackendAIWebUI extends BackendAIWebUI_base {
_offlineIndicatorOpened: boolean;
_offline: boolean;
config: any;
appBody: any;
appPage: any;
contentBody: any;
mainToolbar: any;
Expand Down
Loading