feat: add copy button for full image name in session launcher and environments page #2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @ironAiken2 and the rest of your teammates on |
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 5.41% | 338/6246 |
| 🔴 | Branches | 4.92% (-0% 🔻) |
214/4346 |
| 🔴 | Functions | 3.07% | 63/2053 |
| 🔴 | Lines | 5.31% | 324/6101 |
Test suite run success
90 tests passing in 11 suites.
Report generated by 🧪jest coverage report action from 0dc3660
ironAiken2
force-pushed
the
feat/copy-buttom-for-image-full-name
branch
from
054f20d
to
fe6fcd9
Compare
ironAiken2
force-pushed
the
feat/copy-buttom-for-image-full-name
branch
from
fe6fcd9
to
4485f56
Compare
Merge activity
|
…ironments page (#2708) ### This PR resolves [giftbox#726](lablup/giftbox#726) issue. This PR enhances the user experience by adding copy functionality for image names in multiple components: 1. In `ImageEnvironmentSelectFormItems.tsx`: - Added a copyable text for the environment/version label, allowing users to easily copy the full image name. 2. In `ImageList.tsx`: - Introduced a new copy button in the image list, enabling users to copy the full image name with a single click. 3. Updated `CopyButton.tsx`: - Added a `defaultIcon` prop to allow customization of the default icon displayed before copying. These changes make it more convenient for users to copy and use image names across the application. |Environments|Session Laucner| |---|---| ||| **Checklist:** - [ ] Documentation - [ ] Test case(s) to demonstrate the difference of before/after
agatha197
force-pushed
the
feat/copy-buttom-for-image-full-name
branch
from
4485f56
to
0dc3660
Compare
|](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/lSyr8xXz1wdXALkJKzVx/8359f664-56bf-49ce-9562-f81a05f3452c.png)||){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves giftbox#726 issue.
This PR enhances the user experience by adding copy functionality for image names in multiple components:
In
ImageEnvironmentSelectFormItems.tsx:In
ImageList.tsx:Updated
CopyButton.tsx:defaultIconprop to allow customization of the default icon displayed before copying.These changes make it more convenient for users to copy and use image names across the application.
Checklist: