Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add copy button for full image name in session launcher and environments page #2708

Merged
merged 1 commit into from
Sep 27, 2024

Commits on Sep 27, 2024

  1. feat: add copy button for full image name in session launcher and env…

    …ironments page (#2708)
    
    ### This PR resolves [giftbox#726](lablup/giftbox#726) issue.
    
    This PR enhances the user experience by adding copy functionality for image names in multiple components:
    
    1. In `ImageEnvironmentSelectFormItems.tsx`:
       - Added a copyable text for the environment/version label, allowing users to easily copy the full image name.
    
    2. In `ImageList.tsx`:
       - Introduced a new copy button in the image list, enabling users to copy the full image name with a single click.
    
    3. Updated `CopyButton.tsx`:
       - Added a `defaultIcon` prop to allow customization of the default icon displayed before copying.
    
    These changes make it more convenient for users to copy and use image names across the application.
    
    |Environments|Session Laucner|
    |---|---|
    |![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/lSyr8xXz1wdXALkJKzVx/8359f664-56bf-49ce-9562-f81a05f3452c.png)|![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/lSyr8xXz1wdXALkJKzVx/f114a788-eaef-41f0-9fb8-0ecbfc1c5129.png)|
    
    **Checklist:**
    
    - [ ] Documentation
    - [ ] Test case(s) to demonstrate the difference of before/after
    ironAiken2 committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    0dc3660 View commit details
    Browse the repository at this point in the history