feat: add enableImportFromHuggingFace option
#2709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org requires the Graphite merge queue for merging into mainAdd the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
6 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @agatha197 and the rest of your teammates on |
agatha197
force-pushed
the
feature/add-import-from-hugging-face-modal
branch
from
77422f2
to
f9c9efd
Compare
agatha197
force-pushed
the
feature/add-enableImportFromHuggingFace-option
branch
from
3b0ef99
to
96dce7b
Compare
agatha197
force-pushed
the
feature/add-import-from-hugging-face-modal
branch
from
f9c9efd
to
d57d172
Compare
agatha197
force-pushed
the
feature/add-enableImportFromHuggingFace-option
branch
from
96dce7b
to
b4b1ee2
Compare
Merge activity
|
# Add support for importing models from Hugging Face This PR introduces a new feature that allows users to import models from Hugging Face. The changes include: - Added a new configuration option `enableImportFromHuggingFace` in `config.toml.sample` - Updated the `BackendAIConfig` type to include the new configuration option - Modified the `VFolderListPage` component to conditionally render the "Import from Hugging Face" button based on the new configuration - Updated the `BackendAILogin` component to handle the new configuration option and pass it to the global client configuration **Checklist:** - [ ] Documentation: Update user documentation to explain the new feature and how to enable it - [x] Minimum required manager version: Backend.AI 24.09 - [x] Test case: Verify that the "Import from Hugging Face" button appears when `enableImportFromHuggingFace` is set to true and is hidden when set to false
yomybaby
force-pushed
the
feature/add-import-from-hugging-face-modal
branch
from
d57d172
to
c333321
Compare
yomybaby
force-pushed
the
feature/add-enableImportFromHuggingFace-option
branch
from
b4b1ee2
to
be6db95
Compare
Base automatically changed from
feature/add-import-from-hugging-face-modal
to
main
September 20, 2024 04:01
graphite-app
bot
deleted the
feature/add-enableImportFromHuggingFace-option
branch
This was referenced Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for importing models from Hugging Face
This PR introduces a new feature that allows users to import models from Hugging Face. The changes include:
enableImportFromHuggingFaceinconfig.toml.sampleBackendAIConfigtype to include the new configuration optionVFolderListPagecomponent to conditionally render the "Import from Hugging Face" button based on the new configurationBackendAILogincomponent to handle the new configuration option and pass it to the global client configurationChecklist:
enableImportFromHuggingFaceis set to true and is hidden when set to false