Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: import and start service from hugging face #2713

Closed

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Sep 20, 2024

Import from Hugging Face Modal Enhancements

This PR implements the functionality to import models from Hugging Face and create model store folders or services. Key changes include:

  • Added importAndStartService mutation to handle the import process
  • Implemented success and error handling for the import operation
  • Added notifications for the successful creation of model store folders and services
  • Updated translations for new UI elements and messages

Checklist:

These changes allow users to easily import models from Hugging Face, creating either a model store folder or a new service. The UI provides feedback on the success of the operation and offers quick navigation to the newly created resources.

Screenshots:

image.png

Copy link

graphite-app bot commented Sep 20, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@github-actions github-actions bot added the size:M 30~100 LoC label Sep 20, 2024
@agatha197 agatha197 force-pushed the feature/import-and-start-service-from-huggingface branch from c84e329 to 574c304 Compare September 20, 2024 16:11
@agatha197 agatha197 changed the base branch from feature/fetch-README-file-using-url to refactor/remove-checking-url-and-add-more-inputs September 20, 2024 16:11
@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization size:L 100~500 LoC and removed size:M 30~100 LoC labels Sep 20, 2024
@agatha197 agatha197 force-pushed the feature/import-and-start-service-from-huggingface branch from 574c304 to bae8b47 Compare September 20, 2024 16:25
@agatha197 agatha197 force-pushed the refactor/remove-checking-url-and-add-more-inputs branch from 70d208b to 9bc96f2 Compare September 20, 2024 23:47
@agatha197 agatha197 force-pushed the feature/import-and-start-service-from-huggingface branch from bae8b47 to 8f92c92 Compare September 20, 2024 23:48
@agatha197 agatha197 force-pushed the refactor/remove-checking-url-and-add-more-inputs branch from 9bc96f2 to e7da4b3 Compare September 21, 2024 00:36
@agatha197 agatha197 force-pushed the feature/import-and-start-service-from-huggingface branch 2 times, most recently from 178e43a to b72d152 Compare September 21, 2024 16:12
@agatha197 agatha197 changed the base branch from refactor/remove-checking-url-and-add-more-inputs to feature/improve-form-item-and-switch-to-README-preview-on-validation-check September 21, 2024 16:12
@agatha197 agatha197 marked this pull request as ready for review September 21, 2024 16:21
@agatha197 agatha197 force-pushed the feature/import-and-start-service-from-huggingface branch 2 times, most recently from 01ba4b2 to a6bc0f6 Compare September 21, 2024 17:17
@agatha197 agatha197 force-pushed the feature/improve-form-item-and-switch-to-README-preview-on-validation-check branch from 7bab3a6 to eef5ec0 Compare September 21, 2024 17:19
@agatha197 agatha197 force-pushed the feature/import-and-start-service-from-huggingface branch from a6bc0f6 to b8ee704 Compare September 21, 2024 17:19
@yomybaby yomybaby changed the base branch from feature/improve-form-item-and-switch-to-README-preview-on-validation-check to graphite-base/2713 September 21, 2024 21:21
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opening the folder for Notification is only available when the current WebUI project is "model-store", otherwise it will throw an error. The reason is that the imported folder is a "project" folder of "model-store" project.

react/src/components/ImportFromHuggingFaceModal.tsx Outdated Show resolved Hide resolved
@agatha197 agatha197 force-pushed the feature/import-and-start-service-from-huggingface branch from b8ee704 to aeb9e63 Compare September 22, 2024 01:06
@agatha197 agatha197 changed the base branch from graphite-base/2713 to main September 22, 2024 01:06
@agatha197 agatha197 force-pushed the feature/import-and-start-service-from-huggingface branch from aeb9e63 to 961ca0b Compare September 22, 2024 12:21
Copy link

github-actions bot commented Sep 22, 2024

Coverage report for ./react

St.
Category Percentage Covered / Total
🔴 Statements 5.41% 338/6246
🔴 Branches
4.94% (+0.02% 🔼)
214/4330
🔴 Functions
3.07% (+0% 🔼)
63/2051
🔴 Lines 5.31% 324/6101

Test suite run success

90 tests passing in 11 suites.

Report generated by 🧪jest coverage report action from 7e3fa57

@agatha197 agatha197 marked this pull request as draft September 22, 2024 15:11
@agatha197 agatha197 force-pushed the feature/import-and-start-service-from-huggingface branch from 961ca0b to 7e3fa57 Compare September 30, 2024 02:59
@github-actions github-actions bot added size:XL 500~ LoC and removed size:L 100~500 LoC labels Sep 30, 2024
Copy link
Contributor Author

@agatha197 agatha197 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

handled with #2717. close this issue.

@agatha197 agatha197 closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:i18n Localization area:ux UI / UX issue. size:XL 500~ LoC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants