Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: import from HuggingFace and show result with modal #2717

Merged
merged 1 commit into from
Sep 23, 2024
Merged

feat: import from HuggingFace and show result with modal #2717

merged 1 commit into from
Sep 23, 2024

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Sep 22, 2024 •
edited
Loading

TR;DR

Import or import and start a new service from HuggingFace and show the result with Modal.

How to test?

  • import only works well.
  • import & start service works well.
  • folder name, service name setting
  • result modal
    • import only
      • user can access a new model folder by clicking 'Open model folder' button.
      • admin can access a new model-store project folder by clicking 'Open model folder'.
      • but, admin cannot access a new model-store project folder when the current project is not 'model-store'.
    • import & start service
      • same as import only for folders
      • added redirect button that can visit new service (allow for both of user, admin)
    • common
      • folder name and service name are displayed below buttons.

Screenshots

  • Only for (super)admin, the current project is not 'model-store'.
    image.png

image.png

  • After clicking import & start service
    image.png
  • After clicking import with 'import only' option
    image.png

Checklist: (if applicable)

@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 22, 2024

Your org requires the Graphite merge queue for merging into main

Add the label “flow:merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “flow:hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

@agatha197 Graphite App
Copy link
Contributor Author

agatha197 commented Sep 22, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @agatha197 and the rest of your teammates on Graphite Graphite

@github-actions github-actions bot added area:ux UI / UX issue. area:i18n Localization size:XL 500~ LoC labels Sep 22, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 22, 2024 •
edited
Loading

Coverage report for ./react

St.❔
 Category Percentage Covered / Total
🔴 Statements 5.4% 337/6238
🔴 Branches 4.95% 214/4322
🔴 Functions 3.07% 63/2052
🔴 Lines 5.3% 323/6093

Test suite run success

90 tests passing in 11 suites.

Report generated by 🧪jest coverage report action from 9b7c75e

@graphite-app Graphite App
Copy link

graphite-app bot commented Sep 22, 2024 •
edited
Loading

Merge activity

  • Sep 22, 11:28 AM EDT: The merge label 'flow:hotfix' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Sep 23, 7:00 AM EDT: agatha197 added this pull request to the Graphite merge queue.
  • Sep 23, 7:02 AM EDT: agatha197 merged this pull request with the Graphite merge queue.

@agatha197 agatha197 added the urgency:5 It is imperative that action be taken right away. label Sep 22, 2024 — with Graphite App
@agatha197 agatha197 force-pushed the feature/import-and-start-service-from-hugging-face-and-show-result-with-modal branch from 15af18c to 4590fe8 Compare September 22, 2024 15:54
@lizable lizable force-pushed the feature/import-and-start-service-from-hugging-face-and-show-result-with-modal branch from 4590fe8 to 9443c5b Compare September 23, 2024 09:02
@lizable lizable mentioned this pull request Sep 23, 2024
Draft
6 tasks
lizable
lizable approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@lizable lizable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine. LGTM.

@agatha197 agatha197 force-pushed the feature/import-and-start-service-from-hugging-face-and-show-result-with-modal branch from 9443c5b to 464b6e5 Compare September 23, 2024 10:32
@agatha197
feat: import from HuggingFace and show result with modal (#2717)
9b7c75e 
### TR;DR
Import or import and start a new service from HuggingFace and show the result with Modal.

### How to test?
- [ ] import only works well.
- [ ] import & start service works well.
- [ ] folder name, service name setting
- [ ] result modal
    - import only
      - [ ] user can access a new model folder by clicking 'Open model folder' button.
      - [ ] admin can access a new model-store project folder by clicking 'Open model folder'.
      - [ ] but, admin cannot access a new model-store project folder when the current project is not 'model-store'.
    - import & start service
      - [ ] same as import only for folders
      - [ ] added redirect button that can visit new service (allow for both of user, admin)
    - common
      - [ ] folder name and service name are displayed below buttons.

### Screenshots
- Only for (super)admin, the current project is not 'model-store'.
![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/83a9fb35-deda-4565-b73b-e8b946a4ba02.png)

![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/e6218cae-853d-4335-8152-59c51608afd7.png)
- After clicking import & start service
![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/ab43ecff-4570-4972-ad52-f4271713a7e8.png)
- After clicking import with 'import only' option
![image.png](https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/2HueYSdFvL8pOB5mgrUQ/3db7daf8-99bc-4bed-bdad-36e96cf5ff67.png)

**Checklist:** (if applicable)

- [x] Mention to the original PR: https://app.graphite.dev/github/pr/lablup/backend.ai-webui/2514/Add-an-Import-from-hugging-face-modal
- [ ] Documentation
- [x] Minium required manager version: 24.03
- [x] Specific setting for review (eg., KB link, endpoint or how to setup):
- [x] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
@agatha197 agatha197 force-pushed the feature/import-and-start-service-from-hugging-face-and-show-result-with-modal branch from 464b6e5 to 9b7c75e Compare September 23, 2024 11:01
@graphite-app graphite-app bot merged commit 9b7c75e into main Sep 23, 2024
6 checks passed
@graphite-app graphite-app bot deleted the feature/import-and-start-service-from-hugging-face-and-show-result-with-modal branch September 23, 2024 11:02
@agatha197 agatha197 mentioned this pull request Sep 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizable lizable lizable approved these changes

@ironAiken2 ironAiken2 Awaiting requested review from ironAiken2

@rapsealk rapsealk Awaiting requested review from rapsealk

@yomybaby yomybaby Awaiting requested review from yomybaby

@YEONFEEL96 YEONFEEL96 Awaiting requested review from YEONFEEL96

Assignees

@agatha197 agatha197

Labels
area:i18n Localization area:ux UI / UX issue. size:XL 500~ LoC urgency:5 It is imperative that action be taken right away.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agatha197 @lizable