Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: Materialization of the "main" keypair concept #1761

Merged
merged 13 commits into from
Dec 7, 2023
Merged

feature: Materialization of the "main" keypair concept #1761

merged 13 commits into from
Dec 7, 2023

Conversation

fregataa
Copy link
Member

@fregataa fregataa commented Dec 5, 2023 •
edited by achimnol
Loading

  • Implement main_keypair which is unique for every user. the column name is users.main_access_key
  • Superadmins may change a user's main keypair. But a keypair cannot be deleted while it is a main keypair.
  • Update related the CLI and client SDK functions.

Checklist: (if applicable)

  • Milestone metadata specifying the target backport version
  • API server-client counterparts (e.g., manager API -> client SDK)

@fregataa fregataa added this to the 24.03 milestone Dec 5, 2023
@fregataa fregataa requested review from achimnol and lizable December 5, 2023 15:49
@fregataa fregataa self-assigned this Dec 5, 2023
@github-actions github-actions bot added comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:L 100~500 LoC labels Dec 5, 2023
@github-actions github-actions bot added the comp:client Related to Client component label Dec 5, 2023
@lizable lizable mentioned this pull request Dec 6, 2023
Merged
11 tasks
lizable
lizable requested changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@lizable lizable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just found there are a few minor things about "main" and "primary" thing to be fixed.
Let's use the word "main" instead of "primary", especially the comments I mentioned below.

src/ai/backend/client/cli/admin/user.py Outdated Show resolved Hide resolved
src/ai/backend/client/cli/admin/user.py Outdated Show resolved Hide resolved
src/ai/backend/manager/models/user.py Outdated Show resolved Hide resolved
@achimnol achimnol changed the title feature: impl primary keypair feature: Materialization of the "main" keypair concept Dec 7, 2023
achimnol
achimnol requested changes Dec 7, 2023
View reviewed changes
src/ai/backend/manager/registry.py Outdated Show resolved Hide resolved
src/ai/backend/manager/scheduler/dispatcher.py Outdated Show resolved Hide resolved
src/ai/backend/manager/scheduler/predicates.py Outdated Show resolved Hide resolved
@achimnol achimnol modified the milestones: 24.03, 23.09 Dec 7, 2023
@fregataa fregataa requested review from achimnol and lizable December 7, 2023 09:13
@achimnol achimnol enabled auto-merge December 7, 2023 09:20
@achimnol achimnol added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit 02feead Dec 7, 2023
22 checks passed
@achimnol achimnol deleted the feature/disable-delete-unique-keypair branch December 7, 2023 09:24
fregataa added a commit that referenced this pull request Dec 7, 2023
@fregataa @achimnol
feature: Materialization of the "main" keypair concept (#1761)
93296e6 
Backported-from: main
Backported-to: 23.09
Co-authored-by: Joongi Kim <[email protected]>
@lizable lizable mentioned this pull request Dec 8, 2023
Merged
6 tasks
@fregataa fregataa mentioned this pull request Dec 11, 2023
Merged
3 tasks
@achimnol achimnol mentioned this pull request Dec 14, 2023
Open
9 tasks
@fregataa fregataa mentioned this pull request Jan 2, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achimnol achimnol achimnol approved these changes

@lizable lizable Awaiting requested review from lizable

Assignees

@fregataa fregataa

Labels
comp:client Related to Client component comp:manager Related to Manager component require:db-migration Automatically set when alembic migrations are added or updated size:L 100~500 LoC
Projects
None yet
Milestone
23.09
Development

Successfully merging this pull request may close these issues.
3 participants
@fregataa @achimnol @lizable