Support Bazel Modules #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalten
reviewed
Sep 14, 2023
There was a problem hiding this comment.
Awesome stuff, thanks @jondo2010 ! Looking forward to getting rules_appimage bzlmod'ed!
- It looks like the Python changes are unrelated? It would be nice to keep the PR diff clean.
- I'm wondering what's a good way to test the changes in CI. Maybe have a separate CI job that enables bzlmod (not sure we need to add it as a test matrix dimension). In any case adding a test would be great.
- Also please fix the linting issues.
|
Added a test step and linting fixes. |
jondo2010
commented
Sep 15, 2023
| import rules_python.python.runfiles.runfiles | ||
| from python.runfiles import runfiles |
There was a problem hiding this comment.
This change is actually necessary -- Originally this worked by treating the rules_python external folder itself as a Py module, but this doesn't work with bzlmod since the external package names/folders have suffixes and stuff. So this is now "correct".
lalten
reviewed
Sep 19, 2023
| @@ -36,6 +36,9 @@ jobs: | |||
| - name: Run tests | |||
| run: bazel test --test_env=NO_CLEANUP=1 //... | |||
|
|
|||
| - name: Run tests (bzlmod enabled) | |||
There was a problem hiding this comment.
I think we'll need something like (untested):
Suggested change
| - name: Run tests (bzlmod enabled) | |
| - name: Run tests (bzlmod enabled) | |
| if: ${{ matrix.bazel-version != '5.x' }} |
To make CI green
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.