-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Bazel Modules #78
Closed
Closed
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0aa1231
Support Bazel Modules
jondo2010 37aa463
Added version
jondo2010 2f081da
Lint fixup
jondo2010 bd278d5
Added test step with bzlmod enabled
jondo2010 55f3b31
fixes
jondo2010 99e2ba5
Don't test w/ bzlmod for Bazel 5
lalten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
module(name = "rules_appimage", version = "1.2.0") | ||
|
||
bazel_dep(name = "bazel_skylib", version = "1.4.2") | ||
bazel_dep(name = "rules_python", version = "0.25.0") | ||
bazel_dep(name = "rules_cc", version = "0.0.8") | ||
bazel_dep(name = "platforms", version = "0.0.7") | ||
|
||
python = use_extension("@rules_python//python/extensions:python.bzl", "python") | ||
|
||
# These pip deps are only used for the tests, hence the dev_dependency = True | ||
pip = use_extension("@rules_python//python/extensions:pip.bzl", "pip", dev_dependency = True) | ||
pip.parse( | ||
hub_name = "rules_appimage_py_deps", | ||
python_version = "3.11", | ||
requirements_lock = "//:requirements.txt", | ||
) | ||
use_repo(pip, "rules_appimage_py_deps") | ||
|
||
non_module_deps = use_extension("//:deps.bzl", "non_module_deps") | ||
use_repo(non_module_deps, "squashfs-tools") | ||
use_repo(non_module_deps, "zstd") | ||
use_repo(non_module_deps, "appimagetool.png") | ||
use_repo(non_module_deps, "appimage_runtime_aarch64") | ||
use_repo(non_module_deps, "appimage_runtime_armhf") | ||
use_repo(non_module_deps, "appimage_runtime_i686") | ||
use_repo(non_module_deps, "appimage_runtime_x86_64") | ||
|
||
# -- bazel_dep definitions -- # |
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,15 +9,15 @@ | |
from pathlib import Path | ||
from typing import Dict, Iterable, List, NamedTuple, Optional, Tuple | ||
|
||
import rules_python.python.runfiles.runfiles | ||
from python.runfiles import runfiles | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This change is actually necessary -- Originally this worked by treating the |
||
|
||
|
||
def _get_path_or_raise(path: str) -> Path: | ||
"""Return a Path to a file in the runfiles, or raise FileNotFoundError.""" | ||
runfiles = rules_python.python.runfiles.runfiles.Create() | ||
if not runfiles: | ||
files = runfiles.Create() | ||
if not files: | ||
raise FileNotFoundError("Could not find runfiles") | ||
runfile = runfiles.Rlocation(path) | ||
runfile = files.Rlocation(path) | ||
if not runfile: | ||
raise FileNotFoundError(f"Could not find {path} in runfiles") | ||
return Path(runfile) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we'll need something like (untested):
To make CI green