Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor rollbacks #197

Merged
merged 26 commits into from
Aug 15, 2024
Merged

Refactor rollbacks #197

merged 26 commits into from
Aug 15, 2024

Conversation

MarcosNicolau
Copy link
Contributor

@MarcosNicolau MarcosNicolau commented Aug 14, 2024 •
edited
Loading

This refactor abstract rollbacks to support an easier integration with new rollbackable fields. For that a new World struct is created to encapsulate all the those fields. See more #196. Link to the respective integrations prs:

This was referenced Aug 15, 2024
Merged
Merged
juan518munoz
juan518munoz approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@juan518munoz juan518munoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcosNicolau MarcosNicolau marked this pull request as ready for review August 15, 2024 14:01
@MarcosNicolau MarcosNicolau mentioned this pull request Aug 15, 2024
Closed
fkrause98
fkrause98 requested changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@fkrause98 fkrause98 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and great job, but I want do discuss one thing mostly:

  • RefCell borrows should be done inside methods so we're 100% certain the ref is dropped,
    and we don't panic.

src/lib.rs Outdated Show resolved Hide resolved
src/op_handlers/far_call.rs Outdated Show resolved Hide resolved
src/op_handlers/log.rs Show resolved Hide resolved
src/op_handlers/opcode_decommit.rs Outdated Show resolved Hide resolved
src/world.rs Outdated Show resolved Hide resolved
MarcosNicolau
MarcosNicolau commented Aug 15, 2024
View reviewed changes
src/world.rs Outdated Show resolved Hide resolved
IAvecilla
IAvecilla reviewed Aug 15, 2024
View reviewed changes
.gitmodules Outdated
@@ -1,3 +1,4 @@
[submodule "era-compiler-tester"]
path = era-compiler-tester
url = https://github.com/lambdaclass/era-compiler-tester.git
branch = refactor-rollbacks
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add EOL here

src/world.rs Outdated Show resolved Hide resolved
@MarcosNicolau MarcosNicolau merged commit 7d2fd8b into main Aug 15, 2024
183 checks passed
@MarcosNicolau MarcosNicolau deleted the refactor-rollbacks branch August 15, 2024 18:57
@MarcosNicolau MarcosNicolau mentioned this pull request Aug 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fkrause98 fkrause98 fkrause98 approved these changes

@juan518munoz juan518munoz juan518munoz approved these changes

@IAvecilla IAvecilla IAvecilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MarcosNicolau @fkrause98 @juan518munoz @IAvecilla