Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt era_vm to new world struct #232

Merged
merged 2 commits into from
Aug 15, 2024
Merged

Adapt era_vm to new world struct #232

merged 2 commits into from
Aug 15, 2024

Conversation

MarcosNicolau
Copy link

What ❔

Adapts the era_vm to the new world struct. Merge once this pr gets merged.

Why ❔

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zk fmt and zk lint.

@MarcosNicolau MarcosNicolau mentioned this pull request Aug 15, 2024
Merged
@MarcosNicolau MarcosNicolau marked this pull request as ready for review August 15, 2024 14:17
juan518munoz
juan518munoz approved these changes Aug 15, 2024
View reviewed changes
Copy link

@juan518munoz juan518munoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MarcosNicolau MarcosNicolau merged commit 08cf08f into era_vm_integration_v2 Aug 15, 2024
9 of 44 checks passed
@MarcosNicolau MarcosNicolau deleted the world-adaptation branch August 15, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juan518munoz juan518munoz juan518munoz approved these changes

Assignees
No one assigned
Labels
external-contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcosNicolau @juan518munoz