♻️ Move generic hashing and storage utilities from lamindb into lamindb-setup
#661
Conversation
|
Could you cross-link this with the work package? |
Done! |
| @@ -484,3 +485,65 @@ def create_path(path: UPath, access_token: Optional[str] = None) -> UPath: | |||
| secret=credentials["secret"], | |||
| token=credentials["token"], | |||
| ) | |||
|
|
|||
|
|
|||
| def get_stat_file_cloud(stat: Dict) -> Tuple[int, str, str]: | |||
There was a problem hiding this comment.
We need tests for this, @bpenteado!
In lamindb, this was covered, now, I fear, it's uncovered by CI.
My guess is that there were no fine-grained unit tests in lamindb for this, but coverage came through more high-level functionality.
Given this is in lamindb-setup now and the interfaces are used by laminhub and lamindb, we need a more fine-grained test that reflects needs in both downstream repos (they should be the same if we design the code well).
There was a problem hiding this comment.
Here is an issue for this: #665
| @@ -0,0 +1,35 @@ | |||
| import base64 | |||
There was a problem hiding this comment.
I fear these tests don't executed - see the noxfile. I'll take care of this.
lamindb-setuplamindb#1476