Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 313 to PyPi publish #218

Merged
merged 6 commits into from
Oct 16, 2024

Conversation

raphaelshirley
Copy link
Member

@raphaelshirley raphaelshirley commented Oct 15, 2024

Closes #215

We need to extend testing to match built versions.

Code Quality

  • I have read the Contribution Guide
  • My code follows the code style of this project
  • My code builds (or compiles) cleanly without any errors or warnings
  • My code contains relevant comments and necessary documentation

Project-Specific Pull Request Checklists

Bug Fix Checklist

  • My fix includes a new test that breaks as a result of the bug (if possible)
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

New Feature Checklist

  • I have added or updated the docstrings associated with my feature using the NumPy docstring format
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover my new feature
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

Documentation Change Checklist

Build/CI Change Checklist

  • If required or optional dependencies have changed (including version numbers), I have updated the README to reflect this
  • If this is a new CI setup, I have added the associated badge to the README

Other Change Checklist

  • Any new or updated docstrings use the NumPy docstring format.
  • I have updated the tutorial to highlight my new feature (if appropriate)
  • I have added unit/End-to-End (E2E) test cases to cover any changes
  • My change includes a breaking change
    • My change includes backwards compatibility and deprecation warnings (if possible)

@raphaelshirley
Copy link
Member Author

Strange the c++ code coverage is now failing on the 3.10 test.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.40%. Comparing base (ee3a99c) to head (0123193).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
- Coverage   66.65%   66.40%   -0.25%     
==========================================
  Files          50       50              
  Lines        6229     6225       -4     
  Branches      937      941       +4     
==========================================
- Hits         4152     4134      -18     
- Misses       2077     2091      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@raphaelshirley
Copy link
Member Author

@johannct What do you think? It is passing all the tests after I changed one data retrieval test to acomodate Python 3.13. I also added a line to the lcov command to fix the issue that appeared out of nowhere. Finally I added recursive to the sdist commands but I think we'll have to publish to PyPI tp see if that has worked.

Copy link
Member

@johannct johannct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok let's give it a spin. We should try to be a bit more verbose in the commit comments, so that the review is easier. Here I do not know what exactly was the test failure mode with py3.13 nor what the new lcov options are supposed to mean. Comments are a way to share information and gained knowledge.

@johannct
Copy link
Member

please merge and publish as 0.12. But we wont be able to test as now binaries are going to be available with py3.13

@raphaelshirley
Copy link
Member Author

@raphaelshirley
Copy link
Member Author

I will add more commit comments going forward

@johannct
Copy link
Member

You can force from source https://pip.pypa.io/en/latest/cli/pip_install/#install-no-binary

oh right, good catch

@raphaelshirley
Copy link
Member Author

@johan I need an approving review to merge.

@raphaelshirley
Copy link
Member Author

Ah you already did...

@raphaelshirley raphaelshirley merged commit 8adf41f into main Oct 16, 2024
13 of 14 checks passed
@raphaelshirley raphaelshirley deleted the issue/215/extend-python-version-coverage branch October 16, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Python version coverage
2 participants