-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 313 to PyPi publish #218
Added 313 to PyPi publish #218
Conversation
Strange the c++ code coverage is now failing on the 3.10 test. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #218 +/- ##
==========================================
- Coverage 66.65% 66.40% -0.25%
==========================================
Files 50 50
Lines 6229 6225 -4
Branches 937 941 +4
==========================================
- Hits 4152 4134 -18
- Misses 2077 2091 +14 ☔ View full report in Codecov by Sentry. |
It involves explicit handling of __enter__ and __exit__
@johannct What do you think? It is passing all the tests after I changed one data retrieval test to acomodate Python 3.13. I also added a line to the lcov command to fix the issue that appeared out of nowhere. Finally I added recursive to the sdist commands but I think we'll have to publish to PyPI tp see if that has worked. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok let's give it a spin. We should try to be a bit more verbose in the commit comments, so that the review is easier. Here I do not know what exactly was the test failure mode with py3.13 nor what the new lcov options are supposed to mean. Comments are a way to share information and gained knowledge.
please merge and publish as 0.12. But we wont be able to test as now binaries are going to be available with py3.13 |
You can force from source https://pip.pypa.io/en/latest/cli/pip_install/#install-no-binary |
I will add more commit comments going forward |
oh right, good catch |
@johan I need an approving review to merge. |
Ah you already did... |
Closes #215
We need to extend testing to match built versions.
Code Quality
Project-Specific Pull Request Checklists
Bug Fix Checklist
New Feature Checklist
Documentation Change Checklist
Build/CI Change Checklist
Other Change Checklist