Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AlphaVantage adapter #55

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

jdambacher
Copy link
Contributor

In fact of Yahoo's decision to discontinue the Yahoo Finance API, I decided to search for another exchange rate service and found the free AlphaVantage API. You only have to obtain a free API key at https://www.alphavantage.co/support/#api-key

Fixes lexik#54 - lexik:currency:import yahoo not working
@jdambacher
Copy link
Contributor Author

@cedric-g Do you need any information in order to merge this PR?

@jdambacher
Copy link
Contributor Author

Would be very nice, if you can merge this. Adapter is completely tested and working.

@jdambacher
Copy link
Contributor Author

@lexikteam Any update on this?

@gilles-g
Copy link
Member

@jdambacher
Hi,

Sorry for the delay it's difficult this time for us to maintain all theses bundles 😄

I wanted to merge your PR, but I'm not sure about if we have to delete the yahoo adapter in the same PR. This could add some BC for users who still use YahooAdapter.

Maybe you could remove your last commit for this PR, and create an other PR for Yahoo, and I'll create a special tag for this deletion. What do you think?

@gilles-g gilles-g self-assigned this Jul 23, 2018
@jdambacher
Copy link
Contributor Author

@Spike31 No worries!

I think this is the only option, because the yahoo API is completely disabled. I agree this i a BC, but the adapter is currently completely useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants