-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added AlphaVantage adapter #55
base: master
Are you sure you want to change the base?
Conversation
Fixes lexik#54 - lexik:currency:import yahoo not working
@cedric-g Do you need any information in order to merge this PR? |
Would be very nice, if you can merge this. Adapter is completely tested and working. |
@lexikteam Any update on this? |
@jdambacher Sorry for the delay it's difficult this time for us to maintain all theses bundles 😄 I wanted to merge your PR, but I'm not sure about if we have to delete the yahoo adapter in the same PR. This could add some BC for users who still use YahooAdapter. Maybe you could remove your last commit for this PR, and create an other PR for Yahoo, and I'll create a special tag for this deletion. What do you think? |
@Spike31 No worries! I think this is the only option, because the yahoo API is completely disabled. I agree this i a BC, but the adapter is currently completely useless. |
In fact of Yahoo's decision to discontinue the Yahoo Finance API, I decided to search for another exchange rate service and found the free AlphaVantage API. You only have to obtain a free API key at https://www.alphavantage.co/support/#api-key