-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebToken support integration #1041
Conversation
Hi @chalasr and all, It looks good to me. Can you please take time to review this PR and let me know if you see issues, feature or anything that should be addressed here. Many thanks, |
Thanks for the amazing work @Spomky. Review on its way :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First round of comments and questions :)
bf98537
to
8023c60
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some more comments :) I'm really looking forward to merge this.
Also FYI version the 3.x branch of this bundle is going to require PHP 8.1 minimum, so we will be able to remove the specificities there.
c36ec94
to
1d0b7ca
Compare
Hi, I rebased the and finished the last things including the documentation. Many thanks. |
5409710
to
5b1a7ed
Compare
5b1a7ed
to
15a5e3e
Compare
It took time, but here we go, this is in now. Thank you very much @Spomky. |
… with PHP 7.x (webhdx) This PR was merged into the 2.x branch. Discussion ---------- Removed constructor property promotion to fix compatibility with PHP 7.x Looks like #1041 introduced PHP 7.x incompatible change. The issue is constructor property promotion in `\Lexik\Bundle\JWTAuthenticationBundle\Command\EnableEncryptionConfigCommand` class. Commits ------- dd21e04 Removed constructor property promotion to fix compatibility with PHP 7.x
Excellent! TBH I missed this PR and forget to have it in line with the branch. |
This PR aims to integrate Web-Token for issuing and verifying access tokens.
The two processes are separated so that it is possible to issue a token on one server and verify them on another.
The configuration looks like as follow
Complete lists of supported algorithms:
Allow additional claims and header to be disable(removed as too risky)Keyset Rotation Helper(will be part of another PR)