Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
audio: Fix false positives in driver name comparison
Without this change, driver names don't get matched correctly; for example "a" can get matched with "alsa" since it only checks whether the string matches up to the length of the requested driver name.
- Loading branch information
25f9ed8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It turns out there were a few distros inadvertantly relying on this:
https://bugzilla.opensuse.org/show_bug.cgi?id=1189778
Specifically, because SDL 1.2 used
pulse
as the name of the PulseAudio backend and SDL 2.0 usespulseaudio
, distros which setSDL_AUDIODRIVER=pulse
somewhere used to work, but broke with SDL 2.0.16.Do we want to: