PSP: Throw SDL_Quit event upon exit #10551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slouken
reviewed
Aug 16, 2024
src/main/psp/SDL_psp_main.c
Outdated
| @@ -28,7 +30,9 @@ PSP_MAIN_THREAD_ATTR(THREAD_ATTR_VFPU | THREAD_ATTR_USER); | |||
|
|
|||
| int sdl_psp_exit_callback(int arg1, int arg2, void *common) | |||
| { | |||
| sceKernelExitGame(); | |||
| SDL_Event exit_event; | |||
| exit_event.quit = (SDL_QuitEvent) {SDL_QUIT, SDL_GetTicks()}; | |||
There was a problem hiding this comment.
Please zero the event and fill out the members individually, like the other places we sent SDL_QUIT.
Also, can you target main with new PRs? In this case the event name changed, so it's fine to have this and a separate PR for main, but in general our workflow is making changes in main and then cherry-picking to the SDL2 branches.
Thanks!
There was a problem hiding this comment.
Okay, my bad. I fixed it now. I will create the PR for SDL3.
sharkwouter
force-pushed
the
psp-fix-home-button-handling
branch
from
3f0c4d3 to
ef8fa91
Compare
|
Merged, thanks! |
|
It turns out there's already a function for this, so I switched your change to use that instead. |
|
Oh that is useful, I wasn't aware of that. Thanks for making the change! |
|
You're welcome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At the moment closing an SDL2 based application on the Playstation Portable using the home button will forcefully exit. This makes the application unable to make sure that everything exited out fine.
With this change, the user can handle the home button close in a way that makes sense for them. They will be forced to do so, though, as otherwise the application will freeze when trying to exit. I don't see this as different from how SDL2 based applications which do not handle the close button being pressed on PC not exiting, though. I think this is acceptable.
Existing Issue(s)