Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove relative speed scale #11915

Closed
wants to merge 1 commit into from

Conversation

expikr
Copy link
Contributor

@expikr expikr commented Jan 11, 2025

Relative Speed Scale is a hint added only in SDL3 and only implemented on Windows. (EDIT: brainfart, for some reason was thinking of systemscale, which also isn't the case anymore as of recently)

It is therefore unlikely to have had any notable adoption at this point, if at all.

If anything, it is probably treated as a nuisance that needs to be mitigated.

Deleting it for 3.2.0 removes the temptation for people to potentially depend on it, whether it be developers or tinkerers, before a potentially more suitable interface is conceived.

(aside: @slouken I see that 3.2.0 has a due date of Jan 15, is that a hard date or just an approximate projection?)

@slouken
Copy link
Collaborator

slouken commented Jan 11, 2025

This hint isn't only implemented on Windows, it applies everywhere. However, it's also something that can easily be implemented by the application. Let me consider this.

@slouken
Copy link
Collaborator

slouken commented Jan 11, 2025

What is the rationale for removing this? Is there any reason why this can't apply on top of any other interface we create?

@expikr
Copy link
Contributor Author

expikr commented Jan 11, 2025

Because the hint is end-user alterable, so if the developer isn't already aware of it they'll be surprised until they discover its existence. A catch-22, if you will. Removing it serves the principle of least surprise.

And for my personal taste, it's also just not very useful and only adds coupling to the system.

@slouken
Copy link
Collaborator

slouken commented Jan 11, 2025

Because the hint is end-user alterable

That's one of the advantages of it. If a user needs to adjust the sensitivity of the mouse and the application doesn't provide a way to do that, they can.

@slouken
Copy link
Collaborator

slouken commented Jan 11, 2025

This hint already exists in SDL2 and is explained in https://www.studyplan.dev/sdl-dev/sdl2-relative-mode. We should not remove it.

@slouken slouken closed this Jan 11, 2025
@expikr expikr changed the title remove relative speed scale apply relative speed/system scale sequentially Jan 12, 2025
@expikr expikr changed the title apply relative speed/system scale sequentially remove relative speed scale Jan 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants