Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpu: Initialize Metal stencil format even if stencil test is disabled #11924

Merged
merged 1 commit into from
Jan 12, 2025
Merged

gpu: Initialize Metal stencil format even if stencil test is disabled #11924

merged 1 commit into from
Jan 12, 2025

Conversation

flibitijibibo
Copy link
Collaborator

TheSpydog
TheSpydog requested changes Jan 12, 2025
View reviewed changes
Copy link
Collaborator

@TheSpydog TheSpydog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think adjusting the pixel format assignment like I noted is all we need to do here -- NULL/nil is a valid stencil descriptor, meaning "disable the stencil test for the front/back". So we don't need to set a default state manually.

@TheSpydog TheSpydog self-requested a review January 12, 2025 20:46
@TheSpydog TheSpydog changed the title gpu: Initialize Metal stencil state more aggressively gpu: Initialize Metal stencil format even if stencil test is disabled Jan 12, 2025
@slouken slouken merged commit 3df0767 into libsdl-org:main Jan 12, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSpydog TheSpydog TheSpydog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GPU: Metal requires initialization for depth stencil format
3 participants
@flibitijibibo @TheSpydog @slouken