-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to show or hide menu items #172
Allow to show or hide menu items #172
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Please add a *.changes entry too
Please reference the mga issue manatools/libyui-mga#1 |
The plan is to add a big .changes entry when we are going to merge sprint-108 into master. Right now, sprint-108 contains several new features that deserve a comment in the changes file. |
Commented here manatools/libyui-mga#1 (comment). |
Now I realize that ideally we should have an automated test case, but I am not done making the framework for that just yet 😃 But could you please have a look at yast/yast-ycp-ui-bindings#56 , specifically this test, and check whether |
Yes, I think we can follow that approach to test examples/MenuBar1. Initially, grep should find the menu label, and then, after "clicking" the "Visible" checkbox, the menu should not be found by grep. |
Note: This PR is going to be merged into sprint-108 branch instead of master. There are some WIP features (i.e., nesting tables) and they all will be merged together into master to bump so versions only once.
Problem
A new YMenuBar was added to libyui, but it lacks of the capability to show/hide items. Although such feature is not used by YaST at all, it is still useful for some third-party users of the library (i.e., libyui-mga).
Solution
Extend public API of YMenuBar to allow to indicate whether an item is visible or not. Note that it is possible to hide both: top level menus and also menu items.
See examples/MenuBar1.cc for an usage example.
Changes
The sprint-108 branch is accumulating several new features. The plan is to merge them all into master and bump the so versions only once. At that time, we will provide an entry in the changes file. Here is a proposal for that changes entry: