Allow to show or hide menu items #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvidner
reviewed
Sep 30, 2020
joseivanlopez
force-pushed
the
visible_menu_item
branch
from
ac8c76a to
8718712
Compare
|
Code LGTM, and thanks for fixing the indentation! Please have the intended *.changes entry for this package reviewed here, including the bsc/jsr reference. |
mvidner
approved these changes
Oct 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This PR is going to be merged into sprint-108 branch instead of master. There are some WIP features (i.e., nesting tables) and they all will be merged together into master to bump so versions only once.
See https://github.com/libyui/libyui/pull/172.
Changes
The sprint-108 branch is accumulating several new features. The plan is to merge them all into master and bump the so versions only once. At that time, we will provide an entry in the changes file. Here is a proposal for that changes entry: