Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce the notion of a default SessionProtocol #6128

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

minor fixes

f9cb6bd
Select commit
Loading
Failed to load commit list.
Open

Introduce the notion of a default SessionProtocol #6128

minor fixes
f9cb6bd
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 27, 2025 in 1s

74.40% (-0.04%) compared to 3b27340

View this Pull Request on Codecov

74.40% (-0.04%) compared to 3b27340

Details

Codecov Report

Attention: Patch coverage is 84.09091% with 14 lines in your changes missing coverage. Please review.

Project coverage is 74.40%. Comparing base (3b27340) to head (f9cb6bd).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
...rp/armeria/internal/common/RequestTargetCache.java 66.66% 0 Missing and 3 partials ⚠️
.../linecorp/armeria/client/thrift/ThriftClients.java 57.14% 3 Missing ⚠️
...p/armeria/internal/client/SessionProtocolUtil.java 71.42% 2 Missing ⚠️
...orp/armeria/client/eureka/EurekaEndpointGroup.java 0.00% 2 Missing ⚠️
.../armeria/server/eureka/EurekaUpdatingListener.java 0.00% 2 Missing ⚠️
.../com/linecorp/armeria/client/grpc/GrpcClients.java 50.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #6128      +/-   ##
============================================
- Coverage     74.44%   74.40%   -0.04%     
- Complexity    22059    22219     +160     
============================================
  Files          1942     1960      +18     
  Lines         82033    82333     +300     
  Branches      10736    10740       +4     
============================================
+ Hits          61070    61262     +192     
- Misses        15854    15948      +94     
- Partials       5109     5123      +14

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov