Update git hash #11
Update git hash #11
Conversation
|
|
||
|
|
||
| [dependencies] | ||
| vello = { workspace = true } | ||
| bodymovin = { git = "https://github.com/vectorgameexperts/bodymovin-rs" } | ||
| bodymovin = { git = "https://github.com/Traverse-Research/bodymovin-rs.git" } |
There was a problem hiding this comment.
This needs to use a specific rev, as is linebender policy (I don't think this is written down anywhere). This should have been set previously as well. You can understand that this is especially important for external code.
I also think the PR body should explain the differences in this fork
There was a problem hiding this comment.
Both the vectorgameexperts and Traverse-Research forks seem to be identical with HEAD at e65aea9a701a0c934382ae0037343ecb0ac6976a. We should certainly pin to that rev and I guess which fork to use doesn't matter too much when it's pinned.
There was a problem hiding this comment.
Yeah I made the fork for no real reason, so far, I can revert this also. But we should indeed pin to the right hash.
|
Going to close this as now we should be pinning to 0.1 (vello has an official release) and it is likely that we will be removing |
This bumps the hash of to one later in
vello.It also specifies
default-features = falseso we can use this project withoutwgpuon our end.