Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update git hash #11

Closed
wants to merge 2 commits into from
Closed

Update git hash #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
10afed3
Update git hash
Jasper-Bekkers Oct 12, 2023
9ba86f1
Update to fork
Jasper-Bekkers Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,9 @@ edition.workspace = true
repository.workspace = true

[workspace.dependencies]
vello = { git = "https://github.com/linebender/vello", rev = "b0303ccf98df15a8b196272720d364a56f7304ba" }
vello = { git = "https://github.com/linebender/vello.git", rev = "34d313d0decc6c3ddbb9185195356ce5accde305", default-features = false }


[dependencies]
vello = { workspace = true }
bodymovin = { git = "https://github.com/vectorgameexperts/bodymovin-rs" }
bodymovin = { git = "https://github.com/Traverse-Research/bodymovin-rs.git" }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to use a specific rev, as is linebender policy (I don't think this is written down anywhere). This should have been set previously as well. You can understand that this is especially important for external code.

I also think the PR body should explain the differences in this fork

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the vectorgameexperts and Traverse-Research forks seem to be identical with HEAD at e65aea9a701a0c934382ae0037343ecb0ac6976a. We should certainly pin to that rev and I guess which fork to use doesn't matter too much when it's pinned.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I made the fork for no real reason, so far, I can revert this also. But we should indeed pin to the right hash.