Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no logout sound #119

Merged
merged 2 commits into from
Sep 2, 2024
Merged

Conversation

zsien
Copy link
Member

@zsien zsien commented Jun 20, 2024

@zsien zsien requested a review from a team June 20, 2024 08:46
@deepin-ci-robot
Copy link

deepin pr auto review

关键摘要:

  • generateDevice函数中,如果carddevice都为空,则返回默认值"default"。但在PrepareShutdownSound函数中,cfg.Cardcfg.Device可能为空,但仍然尝试进行格式化,这可能导致运行时错误。
  • PrepareShutdownSound函数中,shutdownCfg.CanPlay被设置为true,但没有相应的注释说明为什么这样做,以及这个设置的实际作用。
  • PrepareShutdownSound函数中的shutdownCfg.ThemeshutdownCfg.Event被设置但没有进行任何操作,这可能是不完整的实现。
  • PrepareShutdownSound函数中的shutdownCfg.ThemeshutdownCfg.Event被设置但没有进行任何操作,这可能是不完整的实现。
  • PrepareShutdownSound函数中的shutdownCfg.ThemeshutdownCfg.Event被设置但没有进行任何操作,这可能是不完整的实现。

是否建议立即修改:

Copy link

TAG Bot

TAG: 6.0.12
EXISTED: no
DISTRIBUTION: unstable

@zsien
Copy link
Member Author

zsien commented Jun 20, 2024

/topic dpidaemon

@deepin-ci-robot
Copy link

Add topic: dpidaemon successed.

@zsien
Copy link
Member Author

zsien commented Jun 20, 2024

/integr-topic dpidaemon

@deepin-ci-robot
Copy link

Integrated with pr deepin-community/Repository-Integration#1628

@zsien
Copy link
Member Author

zsien commented Jun 20, 2024

/topic ddcci-logoutSound-powerBtn

@deepin-ci-robot
Copy link

Add topic: ddcci-logoutSound-powerBtn successed.

@zsien
Copy link
Member Author

zsien commented Jun 20, 2024

/integr-topic ddcci-logoutSound-powerBtn

@deepin-ci-robot
Copy link

Integrated with pr deepin-community/Repository-Integration#1629

@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, yixinshark, zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yixinshark yixinshark merged commit bac8779 into linuxdeepin:master Sep 2, 2024
18 checks passed
@deepin-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: BLumia, yixinshark, zsien

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zsien zsien deleted the zs/fix/logoutsound branch September 2, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants