[RTG][Elaboration] Support labels #8107
Merged
+133
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maerhart
commented
Jan 29, 2025
maerhart
commented
Jan 29, 2025
| @@ -1026,6 +1109,7 @@ class Elaborator : public RTGOpVisitor<Elaborator, FailureOr<DeletionKind>> { | |||
| DenseMap<Value, ElaboratorValue> state; | |||
|
|
|||
| uint64_t virtualRegisterID = 0; | |||
| uint64_t uniqueLabelID = 1; | |||
There was a problem hiding this comment.
Similar to VirtualRegisters, UniqueLabels could rely on a malloc'd address instead giving each one a unique ID.
youngar
approved these changes
Jan 30, 2025
maerhart
force-pushed
the
maerhart-rtg-emission-labels
branch
from
3989308 to
135f067
Compare
maerhart
force-pushed
the
maerhart-rtg-elaboration-labels
branch
from
98b2f4c to
122c8bc
Compare
maerhart
force-pushed
the
maerhart-rtg-elaboration-labels
branch
from
122c8bc to
1eb5b5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.