Create a licence_test rule #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chris Frantz <[email protected]>
milesdai
approved these changes
Sep 21, 2022
rules/rules.bzl
Outdated
| default = "//rules:licence-checker-config.template.hjson", | ||
| allow_single_file = True, | ||
| ), | ||
| "_sh_runfiles": attr.label( |
There was a problem hiding this comment.
Are we using the _sh_runfiles attribute anywhere in this rule, or can it be removed?
There was a problem hiding this comment.
Apparently not. Removed.
The `license_test` rule executes the licence checker as a bazel test (rather than an executable), thus allowing an upstream project to use the rule as part of a set of presubmit tests. Signed-off-by: Chris Frantz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
license_testrule executes the licence checker as a bazel test(rather than an executable), thus allowing an upstream project to
use the rule as part of a set of presubmit tests.
Signed-off-by: Chris Frantz [email protected]