[racl] Follow-up fixes to TLUL adapter and reg_top

[Razer6]

This PR is a follow up to the review in #26004 (review):

It adds:

1. Proper qualification of the read and write request with the necessary TLUL signals for the reg and sram adapter
2. Properly qualify the error log computation in the reg_top with the access control signal coming from the reg_adapter.

[rswarbrick]

I'm convinced that this is cleaner code, so it looks like the right thing to do. But does it actually change behaviour? I think the parameter is only used to qualify racl_error_o. This, in turn, is only true if we hit a register that doesn't have a matching racl permission and every register gets a permission if EnableRacl is false.

Is that correct? Probably worth explaining in the commit message why the change is needed (either cleaning stuff up or fixing some bug that Rupert didn't see!)

[Razer6]

No there is no change in behaviour. Is proposed by Adrian, this is jus a safeguard to not send out a spurious racl error if RACL is disabled. Nothing else.

[Razer6]

I included that in the commit message.

[alees24]

@rswarbrick If the racl_error_o generation logic is correct, such that RACL errors cannot be raised spuriously, then it has no functional impact on non-RACL designs. It's belt'n'braces.

[alees24]

Thanks for fixing up the rd_req/wr_req logic in the two adapters. Just the templated (+autogen) 'racl_error_o' logic that needs fixing now, I think.

[alees24]

@rswarbrick If the racl_error_o generation logic is correct, such that RACL errors cannot be raised spuriously, then it has no functional impact on non-RACL designs. It's belt'n'braces.

[alees24]

Thanks, LGTM.

[alees24]

CHANGE AUTHORIZED: hw/ip/i2c/rtl/i2c.sv
CHANGE AUTHORIZED: hw/ip/mbx/rtl/mbx.sv
CHANGE AUTHORIZED: hw/ip/pwm/rtl/pwm.sv
CHANGE AUTHORIZED: hw/ip/spi_host/rtl/spi_host.sv
CHANGE AUTHORIZED: hw/ip/tlul/rtl/tlul_adapter_reg_racl.sv
CHANGE AUTHORIZED: hw/ip/tlul/rtl/tlul_adapter_sram_racl.sv
CHANGE AUTHORIZED: hw/ip/uart/rtl/uart.sv
CHANGE AUTHORIZED: hw/ip_templates/ac_range_check/rtl/ac_range_check.sv.tpl
CHANGE AUTHORIZED: hw/ip_templates/alert_handler/rtl/alert_handler.sv.tpl
CHANGE AUTHORIZED: hw/ip_templates/rv_plic/rtl/rv_plic.sv.tpl

[alees24]

CI failures unrelated.