DM-47187: Update from synthLSST to real ComCam color terms. #23
Conversation
These bits are apparently untested which is ... not great.
Yes, the Monster is self-referential. No, I don't know how to avoid that.
This uses a special loader to get embargoed data and correct the absolute calibration.
| return 7 | ||
| elif band in ["u"]: | ||
| return 5 | ||
|
|
There was a problem hiding this comment.
should this throw an error if given an unknown band instead of returning 10?
| print("C2602 (ComCam)") | ||
| print("Band CalSpec Original Corrected") | ||
| for i, band in enumerate(bands): | ||
| print(f"{band} " |
There was a problem hiding this comment.
does this ever end up double printing this information with
There was a problem hiding this comment.
This is the set of lines when reading in a catalog, and then there is a second pass when doing the spline terms to make sure everything is still normalized (the second pass doesn't change things by more than a couple mmag at most fwiw).
| @@ -303,6 +333,46 @@ def measure_spline_fit( | |||
| mag_spline_values=mag_spline_values, | |||
| ) | |||
|
|
|||
| if self.do_check_c26202_absolute_calibration: | |||
There was a problem hiding this comment.
I would consider moving the code in this if statement to a method since it is comcam observations of c26202 specific and makes the measure_spline_fit method a little less readable
There was a problem hiding this comment.
So I didn't want to move it inside a method since it requires so many dang variables that are part of the main routine. However, I did refactor things a bit to make it more generic and in the future if we have a different calspec absolute calibrator I think it'll be easy to plug it in.
| x=f_nu*throughputs[band]["throughput"]/tput_lambda, | ||
| y=tput_lambda | ||
| y=f_nu*throughputs[band]["throughput"]/tput_lambda, | ||
| x=tput_lambda, |
There was a problem hiding this comment.
thanks for fixing this!
No description provided.