Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-47187: Update from synthLSST to real ComCam color terms. #23

Merged
merged 34 commits into from
Jan 7, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
1df9ed4
Fix bugs in synth code.
erykoff Dec 12, 2024
e0d494c
Add approximate ComCam throughputs based on ITL average throughputs.
erykoff Dec 12, 2024
02793dc
Add calspec C26202 model spectrum for normalizing conversions.
erykoff Dec 12, 2024
9dbdce1
Add Monster and ComCam catalog definitions.
erykoff Dec 13, 2024
e7935f9
Add first part of ComCam color term spline measurement code.
erykoff Dec 13, 2024
08a1013
Add executable to run the ComCam spline measurements.
erykoff Dec 13, 2024
50b6d36
Add missing ComCamSplineMeasurer to __all__.
erykoff Dec 14, 2024
0243f5b
Update Monster and ComCam color ranges.
erykoff Dec 14, 2024
ff8071c
Fix script to measure comcam colors.
erykoff Dec 14, 2024
11e4038
Allow n_nodes to be band dependent.
erykoff Dec 14, 2024
cbcd01d
Actually call the band when choosing n_nodes.
erykoff Dec 14, 2024
ee3fa10
And fix erroneous property.
erykoff Dec 14, 2024
c69ec80
Add band-specific number of nodes to comcam spline measurement.
erykoff Dec 14, 2024
62ffe7f
Replace temporary collection for fgcm stars with proper DRP run.
erykoff Dec 16, 2024
0a50021
Update how to check for a custom catalog reader.
erykoff Dec 16, 2024
fd428bd
Factor out c26202 magnitude calculation for easier re-use.
erykoff Dec 16, 2024
eb68f90
Move c26202 absolute computer to parent class.
erykoff Dec 16, 2024
bbb38a9
Move the c26202 absolute calibration to an afterburner.
erykoff Dec 16, 2024
49bd54d
Fix typo.
erykoff Dec 16, 2024
287c1b7
Fix another typo
erykoff Dec 16, 2024
0187ad2
Fix float/numpy error.
erykoff Dec 16, 2024
76641ec
Apply abs correction to all target fluxes.
erykoff Dec 16, 2024
b8dbb15
Improve c26202 absolute calibration message formatting.
erykoff Dec 16, 2024
665fdc6
Fix absolute calibration printouts.
erykoff Dec 16, 2024
771eea4
Restore initial absolute calibration bit.
erykoff Dec 16, 2024
32a9459
Fix index error.
erykoff Dec 16, 2024
0d026f4
Fix formatting.
erykoff Dec 16, 2024
d9aa07f
Fix formatting again.
erykoff Dec 16, 2024
508f612
Reduce number of g-band spline nodes for comcam.
erykoff Dec 16, 2024
9f91d4b
Add tests for comcam color measurements.
erykoff Dec 16, 2024
a668ab5
Update assemble to use ComCam transformations instead of SynthLSST.
erykoff Dec 16, 2024
fcea04d
Add Monster (DES) to ComCam color terms.
erykoff Dec 17, 2024
6156a81
Make calspec absolute calibration more generic.
erykoff Jan 6, 2025
377cd2f
Raise on illegal ComCam band.
erykoff Jan 6, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions bin.src/measure_comcam_colorterms.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
#!/usr/bin/env python

from lsst.the.monster import ComCamSplineMeasurer

measurer = ComCamSplineMeasurer()
measurer.measure_spline_fit(bands=["u", "g", "r", "i", "z", "y"])
24 changes: 24 additions & 0 deletions colorterms/Monster_to_ComCam_band_g.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
flux_offset: 0.0
nodes:
- 0.35
- 0.7285714285714285
- 1.1071428571428572
- 1.4857142857142858
- 1.8642857142857143
- 2.242857142857143
- 2.6214285714285714
- 3.0
source_color_field_1: monster_DES_g_flux
source_color_field_2: monster_DES_i_flux
source_field: monster_DES_g_flux
source_survey: Monster
spline_values:
- 0.9977035338305718
- 0.9945069060455712
- 0.9945290189002378
- 0.9935595093133707
- 0.9919568364518895
- 0.9880568810813198
- 0.9826858328755973
- 0.9727218091093088
target_survey: ComCam
28 changes: 28 additions & 0 deletions colorterms/Monster_to_ComCam_band_i.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
flux_offset: 0.0
nodes:
- 0.35
- 0.6444444444444444
- 0.9388888888888889
- 1.2333333333333334
- 1.5277777777777777
- 1.8222222222222224
- 2.1166666666666667
- 2.4111111111111114
- 2.7055555555555557
- 3.0
source_color_field_1: monster_DES_g_flux
source_color_field_2: monster_DES_i_flux
source_field: monster_DES_i_flux
source_survey: Monster
spline_values:
- 1.0024897270144373
- 0.9929411338709319
- 0.9827578858690795
- 0.972527362241766
- 0.9596272533424577
- 0.9441152612780851
- 0.9203293140085828
- 0.8948180766545992
- 0.8669012786683447
- 0.8395057765541502
target_survey: ComCam
28 changes: 28 additions & 0 deletions colorterms/Monster_to_ComCam_band_r.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
flux_offset: 0.0
nodes:
- 0.35
- 0.6444444444444444
- 0.9388888888888889
- 1.2333333333333334
- 1.5277777777777777
- 1.8222222222222224
- 2.1166666666666667
- 2.4111111111111114
- 2.7055555555555557
- 3.0
source_color_field_1: monster_DES_g_flux
source_color_field_2: monster_DES_i_flux
source_field: monster_DES_r_flux
source_survey: Monster
spline_values:
- 0.9875867681371967
- 0.9735663747321471
- 0.9601700359973154
- 0.9477505905558333
- 0.9351812661798063
- 0.9204264652100641
- 0.9011205372511717
- 0.8787272652873112
- 0.8524882809693558
- 0.8239493327993768
target_survey: ComCam
18 changes: 18 additions & 0 deletions colorterms/Monster_to_ComCam_band_u.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
flux_offset: 0.0
nodes:
- 0.35
- 0.4375
- 0.5249999999999999
- 0.6124999999999999
- 0.7
source_color_field_1: monster_DES_g_flux
source_color_field_2: monster_DES_r_flux
source_field: monster_SDSS_u_flux
source_survey: Monster
spline_values:
- 1.1744485105957316
- 1.138572963077543
- 1.1166661995392342
- 1.128442879245455
- 1.144844329061915
target_survey: ComCam
22 changes: 22 additions & 0 deletions colorterms/Monster_to_ComCam_band_y.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
flux_offset: 0.0
nodes:
- 0.0
- 0.11666666666666665
- 0.2333333333333333
- 0.35
- 0.4666666666666666
- 0.5833333333333333
- 0.7
source_color_field_1: monster_DES_i_flux
source_color_field_2: monster_DES_z_flux
source_field: monster_DES_y_flux
source_survey: Monster
spline_values:
- 1.0306658767442902
- 1.0188952600271353
- 1.014526124052815
- 1.0115064917525474
- 1.0068120628850747
- 1.0023654531587292
- 0.9976634639826649
target_survey: ComCam
28 changes: 28 additions & 0 deletions colorterms/Monster_to_ComCam_band_z.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
flux_offset: 0.0
nodes:
- 0.0
- 0.07777777777777778
- 0.15555555555555556
- 0.23333333333333334
- 0.3111111111111111
- 0.3888888888888889
- 0.4666666666666667
- 0.5444444444444445
- 0.6222222222222222
- 0.7
source_color_field_1: monster_DES_i_flux
source_color_field_2: monster_DES_z_flux
source_field: monster_DES_z_flux
source_survey: Monster
spline_values:
- 1.0034256417369722
- 0.9823321493075006
- 0.9617081342430235
- 0.9449114281475789
- 0.9304983472860474
- 0.9161310649815223
- 0.9016639437101419
- 0.8855745776192167
- 0.8677137568969393
- 0.8506685283214435
target_survey: ComCam
Binary file added data/calspec/c26202_mod_008.fits
Binary file not shown.
8 changes: 8 additions & 0 deletions data/throughputs/README
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,14 @@ The LSST throughputs (version 1.9) were downloaded from
https://raw.githubusercontent.com/lsst/throughputs/main/baseline/ on
2023-11-03.

The ComCam throughputs were assembled by combining version 1.9 of
lsst/throughputs "lens1", "lens2", "lens3", "m1", "m2", "m3", and "atmos_std"
components with the ITL throughput average as ingested into
`$OBS_LSST_DATA_DIR/comCam/transmission_sensor/r22_s10` (note that all sensors
were assumed to be the same as of 2024-12-12. Then this combined throughput was
multipled by the reference filter curves in
https://raw.githubusercontent.com/lsst/throughputs/main/baseline/.

The DES throughputs were downloaded from
https://noirlab.edu/science/sites/default/files/media/archives/documents/scidoc1884.txt
on 2023-11-03.
Loading
Loading