DM-26553: Uploaded image for project: 'Data Management' Data ManagementDM-26553 Create gen3 unittests and test CreateApFakes pipeline tasks on data. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is for review only and will not be merged.
kfindeisen
reviewed
Sep 18, 2020
| class: lsst.pipe.tasks.processCcdWithFakes.ProcessCcdWithFakesTask | ||
| config: | ||
| insertFakes.doSubSelectSources: True | ||
| python: config.insertFakes.sourceSelectionColName = "isVisitSource" |
There was a problem hiding this comment.
Try to avoid using the python key unless absolutely necessary.
Suggested change
| python: config.insertFakes.sourceSelectionColName = "isVisitSource" | |
| insertFakes.sourceSelectionColName: isVisitSource |
There was a problem hiding this comment.
Thanks, was playing around to find out what worked and left this in. This pull request isn't going to be merged as it was just a way to for me to test the pipeline with data/a repo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for review only of the test pipeline and will not be merged.