Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-26553: Uploaded image for project: 'Data Management' Data ManagementDM-26553 Create gen3 unittests and test CreateApFakes pipeline tasks on data. #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions pipelines/CiHsc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,14 @@ tasks:
doApplyExternalPhotoCalib: False
doApplyExternalSkyWcs: False
doApplySkyCorr: False
createFakes: lsst.ap.pipe.createApFakes.CreateRandomApFakesTask
procWithFakes:
class: lsst.pipe.tasks.processCcdWithFakes.ProcessCcdWithFakesTask
config:
insertFakes.doSubSelectSources: True
python: config.insertFakes.sourceSelectionColName = "isVisitSource"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to avoid using the python key unless absolutely necessary.

Suggested change
python: config.insertFakes.sourceSelectionColName = "isVisitSource"
insertFakes.sourceSelectionColName: isVisitSource

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, was playing around to find out what worked and left this in. This pull request isn't going to be merged as it was just a way to for me to test the pipeline with data/a repo.

coaddFakes:
class: lsst.pipe.tasks.insertFakes.InsertFakesTask
config:
doSubSelectSources: True
sourceSelectionColName: "isTemplateSource"