DM-46357: Add calibration pipelines for new IsrTaskLSST for LSSTComCam and LSSTComCamSim #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czwa
approved these changes
Oct 7, 2024
| cpMeasureBiasDefects: | ||
| class: lsst.cp.pipe.MeasureDefectsCombinedTask | ||
| config: | ||
| badPixelsToFillColumnThreshold: 1000 |
There was a problem hiding this comment.
Do we expect these config options (for all three tasks) to differ between the three cameras?
There was a problem hiding this comment.
I have left them the same for now, because of cargo culting. But I could see these being different for LSSTCam based on defect research.
| instrument: lsst.obs.lsst.LsstComCamSim | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpDefects.yaml | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpDefectsLSST.yaml |
There was a problem hiding this comment.
Have we ever run this on LSSTComCamSim data?
There was a problem hiding this comment.
No, actually. I was asked to leave it in just in case ComCamSim adds defects in the future. But I actually think that it is more likely we will just use the existing defects and apply them and not "find" them so this may not be necessary. But wanted to leave the option open.
erykoff
force-pushed
the
tickets/DM-46357
branch
from
9b4e6a6
to
e1c5581
Compare
erykoff
force-pushed
the
tickets/DM-46357
branch
from
e1c5581
to
ea8e4b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.