-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-46357: Add calibration pipelines for new IsrTaskLSST for LSSTComCam and LSSTComCamSim #274
Merged
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
fe83abf
Move legacy LSSTComCam calibration pipelines to LSSTComCamSim/legacy_…
erykoff 306393a
Move legacy LSSTComCam calibration pipelines to LSSTComCam/legacy_202…
erykoff baf5097
Add new IsrTaskLSST pipeline for LSSTComCamSim bfk.
erykoff 1610d9e
Add new IsrTaskLSST pipeline for LSSTComCamSim bias.
erykoff 6725d7b
Add new IsrTaskLSST pipeline for LSSTComCamSim biasBootstrap.
erykoff a16a517
Add new IsrTaskLSST pipeline for LSSTComCamSim dark.
erykoff 3f54ea2
Add new IsrTaskLSST pipeline for LSSTComCamSim darkBootstrap.
erykoff c571baf
Add new IsrTaskLSST pipeline for LSSTComCamSim defects.
erykoff 993af63
Add new IsrTaskLSST pipeline for LSSTComCamSim flat.
erykoff 1870248
Add new IsrTaskLSST pipeline for LSSTComCamSim flatBootstrap.
erykoff 54b51bc
Add new IsrTaskLSST pipeline for LSSTComCamSim flat (single).
erykoff cc7cdd3
Add new IsrTaskLSST pipeline for LSSTComCamSim ptc plotting.
erykoff d6fa1c0
Add new IsrTaskLSST pipeline for LSSTComCamSim ptc.
erykoff a148eaf
Add new IsrTaskLSST pipeline for LSSTComCamSim cpSky.
erykoff 2cd1355
Update pipeline testing for LSSTComCamSim with IsrTaskLSST.
erykoff 66c0211
Add new IsrTaskLSST pipeline for LSSTComCam bfk.
erykoff 4b56187
Add new IsrTaskLSST pipeline for LSSTComCam bias.
erykoff 6ca3872
Add new IsrTaskLSST pipeline for LSSTComCam biasBootstrap.
erykoff 9ba5f08
Add new IsrTaskLSST pipeline for LSSTComCam dark.
erykoff 52a3746
Add new IsrTaskLSST pipeline for LSSTComCam darkBootstrap.
erykoff dc75662
Add new IsrTaskLSST pipeline for LSSTComCam defects.
erykoff faca3a3
Add new IsrTaskLSST pipeline for LSSTComCam flat.
erykoff cda9c9f
Add new IsrTaskLSST pipeline for LSSTComCam flatBootstrap.
erykoff 67d5364
Add new IsrTaskLSST pipeline for LSSTComCam flat (single chip).
erykoff 842b83e
Add new IsrTaskLSST pipeline for LSSTComCam linearizer.
erykoff 260ba2b
Add new IsrTaskLSST pipeline for LSSTComCam ptc plotting.
erykoff bbd103e
Add new IsrTaskLSST pipeline for LSSTComCam ptc.
erykoff 6c3e89d
Add new IsrTaskLSST pipeline for LSSTComCam cpSky.
erykoff ea8e4b6
Update pipeline tests for LSSTComCam IsrTaskLSST pipelines.
erykoff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,17 @@ | ||
| description: cp_pipe brighter-fatter kernel calibration construction. | ||
| description: LSSTComCam Brighter-Fatter kernel calibration construction. | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpBfk.yaml | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpBfkLSST.yaml | ||
| tasks: | ||
| cpBfkPtcExtract: | ||
| class: lsst.cp.pipe.ptc.PhotonTransferCurveExtractTask | ||
| config: | ||
| # Restrict the covariance range because we do not have | ||
| # dense PTCs for LSSTComCam. | ||
| maximumRangeCovariancesAstier: 8 | ||
| efdSalIndex: 101 | ||
| cpBfkPtcSolve: | ||
| class: lsst.cp.pipe.ptc.PhotonTransferCurveSolveTask | ||
| config: | ||
| maximumRangeCovariancesAstier: 8 | ||
| maximumRangeCovariancesAstierFullCovFit: 8 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,4 @@ | ||
| description: ComCam bias calibration construction | ||
| description: LSSTComCam bias calibration construction | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpBias.yaml | ||
| tasks: | ||
| cpBiasIsr: | ||
| class: lsst.ip.isr.IsrTask | ||
| config: | ||
| doDefect: false | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpBiasLSST.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| description: LSSTComCam bootstrap bias calibration construction | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpBiasBootstrapLSST.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,4 @@ | ||
| description: ComCam dark calibration construction | ||
| description: LSSTComCam dark calibration construction | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpDark.yaml | ||
| tasks: | ||
| cpDarkIsr: | ||
| class: lsst.ip.isr.IsrTask | ||
| config: | ||
| doLinearize: false | ||
| doCrosstalk: false | ||
| doDefect: false | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpDarkLSST.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| description: LSSTComCam bootstrap dark calibration construction | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpDarkBootstrapLSST.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,29 @@ | ||
| description: cp_pipe DEFECT calibration construction from combined images. | ||
| description: cp_pipe LSSTComCam defect calibration construction. | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpDefects.yaml | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpDefectsLSST.yaml | ||
| tasks: | ||
| cpMeasureBiasDefects: | ||
| class: lsst.cp.pipe.MeasureDefectsCombinedTask | ||
| config: | ||
| badPixelsToFillColumnThreshold: 1000 | ||
| saturatedPixelsToFillColumnThreshold: 20 | ||
| saturatedColumnDilationRadius: 2 | ||
| cpMeasureDarkDefects: | ||
| class: lsst.cp.pipe.MeasureDefectsCombinedTask | ||
| config: | ||
| thresholdType: "VALUE" | ||
| darkCurrentThreshold: 3.0 | ||
| badPixelsToFillColumnThreshold: 1000 | ||
| saturatedPixelsToFillColumnThreshold: 20 | ||
| saturatedColumnDilationRadius: 2 | ||
| cpMeasureFlatDefects: | ||
| class: lsst.cp.pipe.MeasureDefectsCombinedWithFilterTask | ||
| config: | ||
| thresholdType: "VALUE" | ||
| fracThresholdFlat: 0.9 | ||
| badPixelsToFillColumnThreshold: 1000 | ||
| cpMergeDefects: | ||
| class: lsst.cp.pipe.MergeDefectsCombinedTask | ||
| config: | ||
| edgesAsDefects: true | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,15 +1,4 @@ | ||
| description: ComCam flat calibration construction | ||
| description: LSSTComCam flat calibration construction | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpFlat.yaml | ||
| tasks: | ||
| cpFlatIsr: | ||
| class: lsst.ip.isr.IsrTask | ||
| config: | ||
| doLinearize: false | ||
| doCrosstalk: false | ||
| doDefect: false | ||
| cpFlatMeasure: | ||
| class: lsst.cp.pipe.CpFlatMeasureTask | ||
| config: | ||
| doVignette: false | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpFlatLSST.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| description: LSSTComCam bootstrap flat construction | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpFlatBootstrapSingleChipLSST.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| description: cp_pipe FLAT calibration construction | ||
| description: LSSTComCam flat calibration construction | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpFlatSingleChip.yaml | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpFlatSingleChipLSST.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,13 @@ | ||
| description: cp_pipe linearity calibration construction. | ||
| description: cp_pipe LSSTComCam linearizer calibration construction. | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpLinearizer.yaml | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpLinearizerLSST.yaml | ||
| tasks: | ||
| cpLinearizerPtcExtract: | ||
| class: lsst.cp.pipe.ptc.PhotonTransferCurveExtractTask | ||
| config: | ||
| efdSalIndex: 101 | ||
| cpLinearizerSolve: | ||
| class: lsst.cp.pipe.LinearitySolveTask | ||
| config: | ||
| maxLinearAdu: 120000 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| description: cp_pipe task to plot Photon Transfer Curve dataset | ||
| description: cp_pipe LSSTComCam task to plot Photon Transfer Curve dataset | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpPlotPtc.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,18 +1,9 @@ | ||
| description: ComCam Photon-Transfer Curve calibration construction. | ||
| description: LSSTComCam Photon-Transfer Curve calibration construction. | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpPtc.yaml | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpPtcLSST.yaml | ||
| tasks: | ||
| cpPtcIsr: | ||
| class: lsst.ip.isr.IsrTask | ||
| config: | ||
| doCrosstalk: false | ||
| doDefect: false | ||
| cpPtcExtract: | ||
| class: lsst.cp.pipe.ptc.PhotonTransferCurveExtractTask | ||
| config: | ||
| matchExposuresType: TIME | ||
| cpPtcSolve: | ||
| class: lsst.cp.pipe.ptc.PhotonTransferCurveSolveTask | ||
| config: | ||
| ptcFitType: EXPAPPROXIMATION | ||
| efdSalIndex: 101 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| description: cp_pipe brighter-fatter kernel calibration construction. | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpBfk.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| description: ComCam bias calibration construction | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpBias.yaml | ||
| tasks: | ||
| cpBiasIsr: | ||
| class: lsst.ip.isr.IsrTask | ||
| config: | ||
| doDefect: false |
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| description: ComCam dark calibration construction | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpDark.yaml | ||
| tasks: | ||
| cpDarkIsr: | ||
| class: lsst.ip.isr.IsrTask | ||
| config: | ||
| doLinearize: false | ||
| doCrosstalk: false | ||
| doDefect: false |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| description: cp_pipe DEFECT calibration construction from combined images. | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpDefects.yaml |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| description: ComCam flat calibration construction | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpFlat.yaml | ||
| tasks: | ||
| cpFlatIsr: | ||
| class: lsst.ip.isr.IsrTask | ||
| config: | ||
| doLinearize: false | ||
| doCrosstalk: false | ||
| doDefect: false | ||
| cpFlatMeasure: | ||
| class: lsst.cp.pipe.CpFlatMeasureTask | ||
| config: | ||
| doVignette: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| description: cp_pipe FLAT calibration construction | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpFlatSingleChip.yaml |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| description: cp_pipe linearity calibration construction. | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpLinearizer.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| description: cp_pipe task to plot Photon Transfer Curve dataset | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpPlotPtc.yaml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| description: ComCam Photon-Transfer Curve calibration construction. | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpPtc.yaml | ||
| tasks: | ||
| cpPtcIsr: | ||
| class: lsst.ip.isr.IsrTask | ||
| config: | ||
| doCrosstalk: false | ||
| doDefect: false | ||
| cpPtcExtract: | ||
| class: lsst.cp.pipe.ptc.PhotonTransferCurveExtractTask | ||
| config: | ||
| matchExposuresType: TIME | ||
| cpPtcSolve: | ||
| class: lsst.cp.pipe.ptc.PhotonTransferCurveSolveTask | ||
| config: | ||
| ptcFitType: EXPAPPROXIMATION |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| description: Sky frame generation pipeline definition. | ||
| instrument: lsst.obs.lsst.LsstComCam | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpSky.yaml | ||
| tasks: | ||
| cpSkyImage: | ||
| class: lsst.cp.pipe.CpSkyImageTask | ||
| config: | ||
| # These values roughly equate to the dimensions of a single detector. | ||
| # As noted below, the sizes are in millimeters, and correspond to a | ||
| # background image of 4096*4096 pixels (4096*0.01=40.96). | ||
| # TODO: Revise these values on DM-43321. | ||
| largeScaleBackground.xSize: 40.96 # in mm | ||
| largeScaleBackground.ySize: 40.96 # in mm | ||
| largeScaleBackground.pixelSize: 0.01 # in mm per pixel |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,33 @@ | ||
| description: cp_pipe brighter-fatter kernel calibration construction. | ||
| description: LSSTComCamSim Brighter-Fatter kernel calibration construction. | ||
| instrument: lsst.obs.lsst.LsstComCamSim | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpBfk.yaml | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpBfkLSST.yaml | ||
| tasks: | ||
| cpBfkIsr: | ||
| class: lsst.ip.isr.IsrTaskLSST | ||
| config: | ||
| overscanCamera.defaultDetectorConfig.defaultAmpConfig.serialOverscanConfig.fitType: "MEAN" | ||
| overscanCamera.defaultDetectorConfig.defaultAmpConfig.doParallelOverscan: false | ||
| doCrosstalk: false | ||
| doLinearize: false | ||
| doDeferredCharge: false | ||
| doDefect: false | ||
| cpBfkPtcExtract: | ||
| class: lsst.cp.pipe.ptc.PhotonTransferCurveExtractTask | ||
| config: | ||
| maximumRangeCovariancesAstier: 8 | ||
| useEfdPhotodiodeData: false | ||
| auxiliaryHeaderKeys: [] | ||
| cpBfkPtcSolve: | ||
| class: lsst.cp.pipe.ptc.PhotonTransferCurveSolveTask | ||
| config: | ||
| maximumRangeCovariancesAstier: 8 | ||
| maximumRangeCovariancesAstierFullCovFit: 8 | ||
| # TODO DM-46439: This can be renamed back to cpBfkSolve when repos | ||
| # are cleaned up for the previous dimensionality error. | ||
| cpBfkSolveX: | ||
| class: lsst.cp.pipe.BrighterFatterKernelSolveTask | ||
| config: | ||
| useCovModelSample: true | ||
| python: | | ||
| config.covModelFluxSample = {"ALL_AMPS": 100000.0} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,13 @@ | ||
| description: ComCam bias calibration construction | ||
| description: LSSTComCamSim bias calibration construction | ||
| instrument: lsst.obs.lsst.LsstComCamSim | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpBias.yaml | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpBiasLSST.yaml | ||
| tasks: | ||
| cpBiasIsr: | ||
| class: lsst.ip.isr.IsrTask | ||
| class: lsst.ip.isr.IsrTaskLSST | ||
| config: | ||
| doDefect: false | ||
| overscanCamera.defaultDetectorConfig.defaultAmpConfig.serialOverscanConfig.fitType: "MEAN" | ||
| overscanCamera.defaultDetectorConfig.defaultAmpConfig.doParallelOverscan: false | ||
| doCrosstalk: false | ||
| doLinearize: false | ||
|
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| description: LSSTComCamSim bootstrap bias calibration construction | ||
| instrument: lsst.obs.lsst.LsstComCamSim | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpBiasBootstrapLSST.yaml | ||
| tasks: | ||
| cpBiasBootstrapIsr: | ||
| class: lsst.ip.isr.IsrTaskLSST | ||
| config: | ||
| overscanCamera.defaultDetectorConfig.defaultAmpConfig.serialOverscanConfig.fitType: "MEAN" | ||
| overscanCamera.defaultDetectorConfig.defaultAmpConfig.doParallelOverscan: false | ||
| doCrosstalk: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,13 @@ | ||
| description: ComCam dark calibration construction | ||
| description: LSSTComCamSim dark calibration construction | ||
| instrument: lsst.obs.lsst.LsstComCamSim | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpDark.yaml | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpDarkLSST.yaml | ||
| tasks: | ||
| cpDarkIsr: | ||
| class: lsst.ip.isr.IsrTask | ||
| class: lsst.ip.isr.IsrTaskLSST | ||
| config: | ||
| doLinearize: false | ||
| overscanCamera.defaultDetectorConfig.defaultAmpConfig.serialOverscanConfig.fitType: "MEAN" | ||
| overscanCamera.defaultDetectorConfig.defaultAmpConfig.doParallelOverscan: false | ||
| doCrosstalk: false | ||
| doLinearize: false | ||
| doDefect: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| description: LSSTComCam bootstrap dark calibration construction | ||
| instrument: lsst.obs.lsst.LsstComCamSim | ||
| imports: | ||
| - location: $CP_PIPE_DIR/pipelines/_ingredients/cpDarkBootstrapLSST.yaml | ||
| tasks: | ||
| cpDarkBootstrapIsr: | ||
| class: lsst.ip.isr.IsrTaskLSST | ||
| config: | ||
| overscanCamera.defaultDetectorConfig.defaultAmpConfig.serialOverscanConfig.fitType: "MEAN" | ||
| overscanCamera.defaultDetectorConfig.defaultAmpConfig.doParallelOverscan: false | ||
| doCrosstalk: false |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we expect these config options (for all three tasks) to differ between the three cameras?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have left them the same for now, because of cargo culting. But I could see these being different for LSSTCam based on defect research.