Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DM-45738: Experiments with extending butler collections API #1053
DM-45738: Experiments with extending butler collections API #1053
Changes from all commits
d8444aa
212d620
ac61b4d
4460259
1ad0ab1
3c3d3b7
077b5e5
8c7236b
5c50057
970f589
ebbc097
9027b0a
4cc657e
b234be3
a49c3fa
066bea5
ff8f771
3d17223
e6251b8
eaafc03
af98c98
a859c71
c6d1cb0
467cc55
13ac826
dc4b3cb
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 66 in python/lsst/daf/butler/_butler_collections.py
Codecov / codecov/patch
python/lsst/daf/butler/_butler_collections.py#L66
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to catch and reraise the SQLAlchemy error in order to have any chance at consistency between
DirectButler
andRemoteButler
.In fact, this seems like a good place to pull some of the CLI script logic into the Butler itself, by providing options for breaking parent relationships where necessary instead of just raising.
Check warning on line 414 in python/lsst/daf/butler/_butler_collections.py
Codecov / codecov/patch
python/lsst/daf/butler/_butler_collections.py#L414