Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Input connection with deferred binding #407

Closed
wants to merge 1 commit into from

Conversation

tgoldina
Copy link
Contributor

@tgoldina tgoldina commented Mar 25, 2024

These are minimal changes to make an input connection with deferred binding, which would allow us to have an input connection with the same dataset type as an output. (The input would have a different dataset reference than the output.)

This is the first step in creating a Quantum Graph, which would process images with persistence. In this use case, the images must be processed in order, each QuantumNode takes prior persistence state and produces its own.

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 82.38%. Comparing base (7c47f2a) to head (aa7e978).

Files Patch % Lines
python/lsst/pipe/base/connections.py 66.66% 3 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #407      +/-   ##
==========================================
+ Coverage   82.36%   82.38%   +0.01%     
==========================================
  Files          93       93              
  Lines       10645    10644       -1     
  Branches     2021     2019       -2     
==========================================
+ Hits         8768     8769       +1     
+ Misses       1521     1520       -1     
+ Partials      356      355       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

… to have the same dataset type as an output.
@tgoldina tgoldina force-pushed the u/tgoldina/defer-binding-conn branch from 9b33caf to aa7e978 Compare March 25, 2024 18:07
@tgoldina tgoldina requested a review from TallJimbo March 25, 2024 18:20
Copy link
Member

@TallJimbo TallJimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes all look good, thanks! I don't recall whether you can just merge this directly or whether we should make a Jira ticket for it (maybe @timj does).

@timj
Copy link
Member

timj commented Mar 28, 2024

Jira please. Tatiana should have access.

@timj
Copy link
Member

timj commented Mar 28, 2024

Also can we have a news fragment please?

@timj
Copy link
Member

timj commented Mar 28, 2024

I've created DM-43572 so this PR should be closed and reopened with the new ticket branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants