Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: typos after spellchecker #1196

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yash251
Copy link

@yash251 yash251 commented Jan 8, 2025

No description provided.

@yash251 yash251 mentioned this pull request Jan 8, 2025
@yash251
Copy link
Author

yash251 commented Jan 8, 2025

@CJ42 please review and let me know.

Copy link
Member

@CJ42 CJ42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these fixes!

Could you please remove the changes you made under:

  • docs/contracts/contracts
  • docs/tools/

We need to update the typos for these under their respective repositories, since the docs in these folders is fetched from there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything under the contracts/contracts folder is a Markdown file autogenerated from the Natspec comments in the Solidity code of the smart contracts repositories:

Therefore, the changes under this folder should not be made here in the docs repository but under these repositories mentioned above. Otherwise, the next time we update the contracts autogenerated docs, the typos will be back.

@@ -16,7 +16,7 @@ Yes, developers have several options for financial support when building on LUKS

## Will LUKSO be listed on additional exchanges?

At the moment, LUKSO is available on [KuCoin](https://www.kucoin.com/de), [Crypto.com](https://crypto.com/), and [Gate.io](https://www.gate.io/). As the network continues to expand, additionl exchanges may consider joining. It is important to note that this decision is entirely at the discretion of the exchanges.
At the moment, LUKSO is available on [KuCoin](https://www.kucoin.com/de), [Crypto.com](https://crypto.com/), and [Gate.io](https://www.gate.io/). As the network continues to expand, additional exchanges may consider joining. It is important to note that this decision is entirely at the discretion of the exchanges.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's strange that spellcheck did not flag that

@@ -325,7 +325,7 @@ const retrievedJsonMetadata = JSON.parse(ethers.toUtf8String(storedMetadata));
{
width: 256,
height: 256,
url: 'ifps://QmW5cF4r9yWeY1gUCtt7c6v3ve7Fzdg8CKvTS96NU9Uiwr',
url: 'ipfs://QmW5cF4r9yWeY1gUCtt7c6v3ve7Fzdg8CKvTS96NU9Uiwr',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! 👌🏻

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as the smart contracts here.
The docs for the tools is fetched directly from each individual tool repository and should be updated in the respective repositories.

@CJ42
Copy link
Member

CJ42 commented Jan 9, 2025

Also could you please wait before making any PR to @lukso/lsp-smart-contracts repository, as we are currently re-organizing the repository to only use the main branch and not have develop anymore.

@yash251
Copy link
Author

yash251 commented Jan 9, 2025

you can ping me after you are done with re-organizing and I can go through it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants