bugfix: fix compilation with logger turned off #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @KSkwarczynski, thank you for contributing to MaCh3! Please wait for MaCh3 developers to review your PR. If no one answers within a week, please message people from this list: https://github.com/orgs/mach3-software/teams/mach3admin . While waiting, please enjoy this  Use this action on your projects. Use jokes on issues instead. |
ewanwm
approved these changes
Jan 7, 2025
cmake/Modules/Logger.cmake
Outdated
| @@ -39,3 +39,11 @@ if(${index} GREATER -1) | |||
| else() | |||
| cmessage(FATAL_ERROR "Invalid log level specified: ${LOG_LEVEL} \n Should be one of: ${VALID_LOG_OPTIONS}") | |||
| endif() | |||
|
|
|||
| # KS: If logger is set to off many functions which sole purpose is to print message will not print anything. Thus variable will not be used and our very picky WErrror will throw errors | |||
| if(LOG_LEVEL STREQUAL "OFF" OR LOG_LEVEL STREQUAL "CRITICAL" OR LOG_LEVEL STREQUAL "ERROR" OR LOG_LEVEL STREQUAL "WARN") | |||
There was a problem hiding this comment.
Could do something like
set(WIGNORE_LIST OFF CRITICAL ERROR WARN)
if(${LOG_LEVEL} IN_LIST WIGNORE_LIST)
instead for extra tidiness?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request description
Fix this: #267
Changes or fixes
Examples