Configurable attributes + COALESCE mysql fix + M2 max exception traces fix #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lsv
changed the title
|
Added a max traces to 10 so if a bug appears it just not dies in M2 - maybe not the cleanest way, but it works, and it generates a error in the log file, so if you try to add text into a Date attribute then it actually skips the product, and continues on, instead of using about 4gb memory and dies of memory :) |
lsv
changed the title
|
Hi @lsv
|
|
Hi @lsv |
marvinhinz
added a commit
to marvinhinz/magmi-m2
that referenced
this pull request
Dec 19, 2019
I copied the workaround from macopedia#54 because the pr is not yet splitted and i needed the functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1: Fix of #53
#2: Fix of COALESCE mysql calls requires the field to be grouped by, so I turned it off with sql_mode