updated README with workaround for not being able to open more than 2… #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perguth
requested changes
Sep 27, 2017
| @@ -60,6 +60,9 @@ constructor) | |||
| - `stream` - if video/voice is desired, pass stream returned from | |||
| `getUserMedia` | |||
|
|
|||
| **NOTE:** It's been observed in Chrome that you cannot establish a connection between more than 2 local peers. | |||
| You can workaround this by opening other tabs in incognito mode. It's unclear which browsers are affected but | |||
| this condition has been observed in Chrome 52 and 53. | |||
There was a problem hiding this comment.
I would rather remove the last sentence: 'It's unclear which browsers are affected but this condition has been observed in Chrome 52 and 53.' Let's keep it terse!
Otherwise I think that's sensible!
There was a problem hiding this comment.
@pguth I'm fine with removing redundant lines, but having details on exactly what versions it has been noticed in is useful.
A 2nd attempt:
**NOTE:** It's been observed in Chrome (v52+) that you cannot establish
a connection between more than 2 local peers. You can workaround this
by opening other tabs in incognito mode.
thoughts?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… local peers #18