Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated README with workaround for not being able to open more than 2… #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

updated README with workaround for not being able to open more than 2… #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ constructor)
- `stream` - if video/voice is desired, pass stream returned from
`getUserMedia`

**NOTE:** It's been observed in Chrome that you cannot establish a connection between more than 2 local peers.
You can workaround this by opening other tabs in incognito mode. It's unclear which browsers are affected but
this condition has been observed in Chrome 52 and 53.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather remove the last sentence: 'It's unclear which browsers are affected but this condition has been observed in Chrome 52 and 53.' Let's keep it terse!

Otherwise I think that's sensible!

Copy link
Contributor Author

@mreinstein mreinstein Sep 27, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pguth I'm fine with removing redundant lines, but having details on exactly what versions it has been noticed in is useful.

A 2nd attempt:

**NOTE:** It's been observed in Chrome (v52+) that you cannot establish 
a connection between more than 2 local peers. You can workaround this
by opening other tabs in incognito mode.

thoughts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be nice :)


### sw.close()

Expand Down