Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dewiz x Sidestream x Arby Spell Improvements #12

Merged
merged 143 commits into from
Oct 25, 2023
Merged
Changes from 1 commit
Commits
Show all changes
143 commits
Select commit Hold shift + click to select a range
6a31eb3
Added ESM auth checks
The-Arbiter May 8, 2023
c1b818c
Added submodule notes
The-Arbiter May 8, 2023
4b4c94a
Updated treatment of PCT_RATE declarations
The-Arbiter May 8, 2023
a35e233
Added rate varname guide
The-Arbiter May 8, 2023
24f2f7b
Updated declaration for math and precision constants (add spacing), a…
The-Arbiter May 8, 2023
3e875cc
Semantics: Changed chainlog to changelog since that is the entry key …
The-Arbiter May 8, 2023
05fe227
RWA onboarding updates
The-Arbiter May 8, 2023
c3dd917
Added changlog (synonym / internal naming for chainlog) to wordlist
The-Arbiter May 8, 2023
fa69b0d
Added submodule hash check command
The-Arbiter May 9, 2023
1e2a6df
Fixed interface semantics as dss-interfaces is practically unmaintained
The-Arbiter May 9, 2023
c98f784
Clarified that deployed contracts are new to system contracts
The-Arbiter May 9, 2023
e211274
Modified quitTo wording
The-Arbiter May 9, 2023
3d03296
Marked submodule hash checks as non-critical while we are waiting for…
The-Arbiter May 9, 2023
43985f1
Added line for dependency cleanup
The-Arbiter May 9, 2023
3b1fd51
Added install function for submodules
The-Arbiter May 10, 2023
8d7b026
Mainnet reviewer checklist only - added timestamp checks
The-Arbiter May 10, 2023
de46baf
Removed section from Goerli reviewer checklist (currently we don't d…
The-Arbiter May 10, 2023
edc3d2c
Fixed CI, changed 'ExecLib' to 'DssExecLib' (semantics)
The-Arbiter May 10, 2023
be0c021
Fixed changelog / chainlog
The-Arbiter May 10, 2023
5f7b26b
Fix an inherited typo
The-Arbiter May 10, 2023
e6fac02
Fixed grammar
The-Arbiter May 11, 2023
cdefd8d
Added SubDAO items (prototype)
The-Arbiter May 23, 2023
38ebf10
Fix typo check
The-Arbiter May 24, 2023
9c2ccca
RWA update for authgemjoin ilk bytes conversion double check
The-Arbiter May 24, 2023
af6fd1b
Added Urn constructor arg notes
The-Arbiter May 24, 2023
dbd513b
Added source locations, updated name of RWA test testFailRWAXXX_PUSH_…
The-Arbiter May 24, 2023
9e4ea09
Added exception to interface naming rule for 'initializable' etc.
The-Arbiter Jun 5, 2023
7eb7566
Updated semantics of what is a 'Deployed Contract' for the sake of th…
The-Arbiter Jun 5, 2023
f921dc0
SubDao -> SubDAO
The-Arbiter Jun 5, 2023
e9712ac
Added PE chainlog fetched address variable naming rule
The-Arbiter Jun 5, 2023
bde0c27
Added enforcement of using ExecLib Core Contract Helpers over chainlog
The-Arbiter Jun 5, 2023
86126e6
Added semantics for exec doc checking for subdao items - only check c…
The-Arbiter Jun 5, 2023
086d61f
Fixed TBD for 'funnels' to say SubDAO proxy
The-Arbiter Jun 5, 2023
d675e58
Enforce SF change comment structure
The-Arbiter Jun 5, 2023
cffa010
Added RWA doc update helper reference
The-Arbiter Jun 5, 2023
8ad8fc8
Added fetch rules
The-Arbiter Jun 5, 2023
08d1faf
Added more SubDAO action rules, moved section to the last section (lo…
The-Arbiter Jun 6, 2023
a1d4f9a
PauseProxy --> Pause Proxy
The-Arbiter Jun 6, 2023
c75edde
Added reference to ink increase accounting rule for val
The-Arbiter Jun 7, 2023
e69f6d7
Added refined 'val' calculation and style rules following call
The-Arbiter Jun 7, 2023
def0b5e
Removed newline to fix formatting
The-Arbiter Jun 7, 2023
1520223
Added requirement for correct 'val' calculation formula for RWA bump(…
The-Arbiter Jun 9, 2023
d7b191e
Updated auth checks to include context, updated RWA constructor param…
The-Arbiter Jun 9, 2023
26d3211
Fixed inherited typo, vat -> jug (for RWA onboarding actions checks)
The-Arbiter Jun 9, 2023
46001f9
Reordered OUTPUT_CONDUIT_PUSH_ABOVE_BALANCE check in test coverage se…
The-Arbiter Jun 9, 2023
0c5c943
Added method for fetching 'val' of RWA for debt consolidation
The-Arbiter Jun 9, 2023
04423eb
Fixed formula typo
The-Arbiter Jun 9, 2023
da6a1c0
Sectioned out checklist, fixed summary semantics
The-Arbiter Jun 12, 2023
ad33d3c
Spacing
The-Arbiter Jun 12, 2023
4fc71cc
Added instructions for inlining onboarding checklists
The-Arbiter Jun 12, 2023
83fc251
Added exception example for 'chainlog fetch must be address type' rule
The-Arbiter Jun 13, 2023
2b36eea
Updated library dependency commit hash comparison reference point
The-Arbiter Jun 13, 2023
adc4190
Added exec hash curl instruction
The-Arbiter Jun 13, 2023
7f6f6ff
Added tilde around 'internal'
The-Arbiter Jun 13, 2023
1ce4e77
Added blanket ESM auth context for newer spellcrafters
The-Arbiter Jun 13, 2023
e0bd03f
Added CREATE2 substitution attack soft-mitigation via selfdestruct ch…
The-Arbiter Jun 13, 2023
f06d24e
Added round up for MIP21 'bump' value rule
The-Arbiter Jun 13, 2023
2f00f18
Change MM euro-centric millions lettering to 'M' because we are a DAO
The-Arbiter Jun 13, 2023
170052e
Added SubDAO content address provenance clarification rules
The-Arbiter Jun 14, 2023
2535dd6
Changed 'sheet' reference to doc and explained that doc is the source…
The-Arbiter Jun 14, 2023
74c3bce
Added subdao address rules
The-Arbiter Jun 14, 2023
4f3ffc8
Fix inherited typo
The-Arbiter Jun 14, 2023
31f9f50
Added exception to chainlog key being varname with MKR instead of MCD…
The-Arbiter Jun 14, 2023
513f2f0
Added double check for exec lib modification
The-Arbiter Jun 14, 2023
2e9be5d
Added reasoning for submodule check in deloyed spell stage
The-Arbiter Jun 14, 2023
7a5a5f9
Updated branch naming method
The-Arbiter Jul 27, 2023
e81d446
Removed unused 'changelog' from spellcheck wordlist
The-Arbiter Jul 27, 2023
f5941fc
Updated Chainlog fetched value var name rule
The-Arbiter Jul 27, 2023
91ff7d9
Removed 'script this eventually' message but retained context for rev…
The-Arbiter Jul 27, 2023
3b2f679
Moved 'External Contract Calls' section to below 'SubDAO content' sec…
The-Arbiter Jul 27, 2023
e60964c
Reworded SubDAO contract licensing not being important
The-Arbiter Jul 27, 2023
ad2bc7d
Added the word 'in' to ESM rely checks
The-Arbiter Jul 27, 2023
74bce12
Fix spellcheck with by adding the word PR'ed
The-Arbiter Jul 27, 2023
4c26c1c
Re-added Payments section to reviewer Goerli checklist with explanati…
The-Arbiter Jul 31, 2023
ac06ae7
Fixed typo and changed 'exec doc' to sheet for a Goerli rule
The-Arbiter Aug 2, 2023
b412dca
Updated payment category wording for DAI and MKR payments
The-Arbiter Aug 3, 2023
38343c2
Updated parameter changes section - added DSR checks, reordered check…
The-Arbiter Aug 10, 2023
e031a54
Added prompt for test coverage section to ensure compliance
The-Arbiter Aug 10, 2023
fd6b073
Removed unused CI and passing test check after casting of Goerli spell
The-Arbiter Aug 10, 2023
f554f79
Reworded 'gas cost' SubDAO spell checklist item as a note for reviewers
The-Arbiter Aug 10, 2023
21685fa
Overhaul of payment checks
The-Arbiter Aug 10, 2023
06e23e6
Added missing CI check the mainnet reviewer checklist
The-Arbiter Aug 10, 2023
d2c24e3
Added Handover stage reviewer checks to prevent parallel malicious sp…
The-Arbiter Aug 10, 2023
d89fb1a
Added 'new-spells' confirmation checklist items, added a check for un…
The-Arbiter Aug 10, 2023
b50cd33
Refined test checklist items
The-Arbiter Aug 10, 2023
34f8d45
Refined test instructions, added env confirmation, removed 'only on g…
The-Arbiter Aug 10, 2023
9e1d5c9
Replicated new test items to other instances
The-Arbiter Aug 10, 2023
612352a
Fixed CI by adding DSR (not necessary) and setDSR
The-Arbiter Aug 10, 2023
2cc5610
Capitalized 'exec doc' instances
The-Arbiter Aug 10, 2023
9f32948
Changed 'doc' to 'exec doc', removed ability to use Forum post as pro…
The-Arbiter Aug 10, 2023
96d9e0c
Cleaned up Goerli reviewer checklist
The-Arbiter Aug 10, 2023
a3a42dc
Cleaned up reviewer checklists, removed ability to use Exec Sheet as …
The-Arbiter Aug 10, 2023
ffb97fd
Cleaned up crafting checklists, reworked subdao deployer documentatio…
The-Arbiter Aug 10, 2023
e430d17
Fixed wordlist CI
The-Arbiter Aug 10, 2023
dc0c1e7
Reworked exec doc, description and beginning-of-checklist items
The-Arbiter Aug 11, 2023
591ab94
Reworked Local Env checks, added 'interface checks' heading
The-Arbiter Aug 11, 2023
e667a94
Constants Match section added, refined old items within the constants…
The-Arbiter Aug 11, 2023
c8e1caa
Various changes to constants and chainlog rules
The-Arbiter Aug 14, 2023
af4b8f6
Fixed 'dssexeclib.sol' which should have used the '.address' extension
The-Arbiter Aug 14, 2023
b80d7c7
Update spell/spell-reviewer-mainnet-checklist.md
The-Arbiter Aug 14, 2023
b4b096e
Update spell/spell-reviewer-goerli-checklist.md
The-Arbiter Aug 14, 2023
a8c0118
Added Debt Ceiling category with scaffold items underneath
The-Arbiter Aug 14, 2023
4a5e1d5
Added pre-merge bad maintenance or other PR protection
The-Arbiter Aug 27, 2023
693d496
Descroption --> Description
The-Arbiter Aug 31, 2023
afd900b
Update spell-crafter-goerli-workflow.md
amusingaxl Sep 22, 2023
60bf298
ipfs and dao resoutions instructions
Oct 4, 2023
d78d0e5
adjust dc instructions
Oct 4, 2023
b7226b2
add instructions to the mainnet ilk adjustments
Oct 4, 2023
48db8a8
cap instructions todo removed
Oct 4, 2023
bc322e0
Add the mainnet opener instructions for exec sheet actions
Oct 4, 2023
69bce64
adjust the raw url extraction instruction to more general
Oct 4, 2023
e85488e
update the subdao deployer policy
Oct 4, 2023
c88a969
as prev commit
Oct 4, 2023
5a7f26c
typos
Oct 4, 2023
f2a7f72
as in prev commit
Oct 4, 2023
cf9e09b
adjust contents as per PR requests
Oct 4, 2023
1ba7aea
remove undesired puntuation
Oct 4, 2023
00301bc
fix: wrong copypasta
Oct 4, 2023
e41def2
alignment
Oct 4, 2023
cd8aae3
move up the rwa line instruction
Oct 5, 2023
8586bc6
feat: add item regarding RWA soft liquidation
amusingaxl Oct 19, 2023
739e338
chore: update mainnet reviewer checklist to match goerli
amusingaxl Oct 19, 2023
b195259
chore: add word to spellcheck exceptions
amusingaxl Oct 19, 2023
2f29584
chore: better wording
Oct 24, 2023
7614bb2
Merge branch '2023-05-10-improvements' of github.com-ses:makerdao/pe-…
Oct 24, 2023
f0ef6c9
govalpha -> Governance Facilitators
Oct 24, 2023
2dc179d
setDSR returned
Oct 24, 2023
fa0fc8f
codeblock setDSR
Oct 24, 2023
20052e5
Update spell/rwa-onboarding-checklist.md
SidestreamSweatyPumpkin Oct 25, 2023
bcc2d99
Update spell/rwa-onboarding-checklist.md
SidestreamSweatyPumpkin Oct 25, 2023
7215b24
Update spell/spell-reviewer-mainnet-checklist.md
SidestreamSweatyPumpkin Oct 25, 2023
184e070
Update spell/spell-reviewer-mainnet-checklist.md
SidestreamSweatyPumpkin Oct 25, 2023
73ff953
Update spell/spell-reviewer-mainnet-checklist.md
SidestreamSweatyPumpkin Oct 25, 2023
931f512
Update spell/spell-reviewer-goerli-checklist.md
SidestreamSweatyPumpkin Oct 25, 2023
1d6a3b4
Update spell/spell-reviewer-goerli-checklist.md
SidestreamSweatyPumpkin Oct 25, 2023
8e67c56
Update spell/rwa-onboarding-checklist.md
SidestreamSweatyPumpkin Oct 25, 2023
65f5732
Update spell/rwa-onboarding-checklist.md
SidestreamSweatyPumpkin Oct 25, 2023
39951d4
Update spell/rwa-onboarding-checklist.md
SidestreamSweatyPumpkin Oct 25, 2023
8078884
Apply suggestions from code review
SidestreamSweatyPumpkin Oct 25, 2023
80fbaa4
Update spell/spell-reviewer-goerli-checklist.md
SidestreamSweatyPumpkin Oct 25, 2023
cb25c1b
add suggestions from review
Oct 25, 2023
374537e
Update spell/rwa-onboarding-checklist.md
SidestreamSweatyPumpkin Oct 25, 2023
4d554e7
Update spell/rwa-onboarding-checklist.md
SidestreamSweatyPumpkin Oct 25, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: add word to spellcheck exceptions
amusingaxl committed Oct 19, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit b19525907dd2bae4d1cc961ec6c2b0c289bc65a9
3 changes: 2 additions & 1 deletion .wordlist.txt
Original file line number Diff line number Diff line change
@@ -138,4 +138,5 @@ PR'ed
DSR
SidestreamColdMelon marked this conversation as resolved.
Show resolved Hide resolved
setDSR
SidestreamColdMelon marked this conversation as resolved.
Show resolved Hide resolved
multisig
EOA
EOA
redemptions