Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Size consistency #555

Closed
willymaps opened this issue Jun 24, 2021 · 2 comments
Closed

Size consistency #555

willymaps opened this issue Jun 24, 2021 · 2 comments
Assignees
@Udobnyj
Labels
p2

Comments

@willymaps
Copy link
Contributor

Icon Request

Seeing all of the maki icons together as one single size (15x15) highlights some inconsistencies in the size/stroke widths used.

Proposing we upsize some icons and downsize others where necessary:

Icons that could be smaller

aquarium, bus, caution (although this is consistent with roadblock), clothing-store, post, suitcase

maki_sm

Icons that could be larger

hot-spring, skateboard, teahouse, village

maki_lg
@Udobnyj Udobnyj self-assigned this Apr 25, 2022
@Udobnyj Udobnyj mentioned this issue May 30, 2022
Merged
@Udobnyj
Copy link
Contributor

Udobnyj commented May 31, 2022 •
edited
Loading

I apologize in advance. There will be a lot of icons.

I took the icons that @willymaps suggested in the description.
After, I checked all the icons for size using blur.
Screen Shot 2022-05-31 at 18 16 21

After that, I checked them in a circle, singled out those cramped in it, and added some icons from my centering task to them.
Screen Shot 2022-05-31 at 18 16 42

In the end, I chose 34 icons to change.
Screen Shot 2022-05-31 at 18 16 49

Well, let's get started. I also add a link on the comparing map, but not for all of them.
Because some, such as "square," are not used.
Pictures "before" and "after" can be viewed by clicking on the spoiler next to the name of the icon (I did this to save space)

bus

bus MAP LINK

img

Screen Shot 2022-05-31 at 15 32 13

Screen Shot 2022-05-31 at 15 45 18

aquarium

aquarium MAP LINK

Screen Shot 2022-05-31 at 15 32 22

Screen Shot 2022-05-31 at 15 32 30

Screen Shot 2022-05-31 at 15 45 23

clothing-store

clothing-store MAP LINK

Screen Shot 2022-05-31 at 15 32 45

Screen Shot 2022-05-31 at 15 32 53

Screen Shot 2022-05-31 at 15 45 28

post

post MAP LINK

Screen Shot 2022-05-31 at 15 33 02

Screen Shot 2022-05-31 at 15 33 14

Screen Shot 2022-05-31 at 15 45 33

religious-jewish

religious-jewish MAP LINK

Screen Shot 2022-05-31 at 15 33 23

Screen Shot 2022-05-31 at 15 33 34

Screen Shot 2022-05-31 at 15 45 38

square

square

Screen Shot 2022-05-31 at 15 33 44

Screen Shot 2022-05-31 at 15 33 52

Screen Shot 2022-05-31 at 15 45 44

square-stroked

square-stroked

Screen Shot 2022-05-31 at 15 34 00

Screen Shot 2022-05-31 at 15 34 08

Screen Shot 2022-05-31 at 15 45 48

marker-stroked

marker-stroked

Screen Shot 2022-05-31 at 15 34 16

Screen Shot 2022-05-31 at 15 34 27

Screen Shot 2022-05-31 at 15 45 53

marker

marker

Screen Shot 2022-05-31 at 15 34 34

Screen Shot 2022-05-31 at 15 34 43

Screen Shot 2022-05-31 at 15 45 57

circle-stroked

circle-stroked

Screen Shot 2022-05-31 at 15 34 51

Screen Shot 2022-05-31 at 15 35 05

Screen Shot 2022-05-31 at 15 46 03

fire-station

fire-station MAP LINK

Screen Shot 2022-05-31 at 15 35 15

Screen Shot 2022-05-31 at 15 35 26

Screen Shot 2022-05-31 at 15 46 09

roadblock

roadblock

Screen Shot 2022-05-31 at 15 35 35

Screen Shot 2022-05-31 at 15 35 42

Screen Shot 2022-05-31 at 15 46 16

caution

caution

Screen Shot 2022-05-31 at 15 35 51

Screen Shot 2022-05-31 at 15 36 00

Screen Shot 2022-05-31 at 15 46 22

suitcase

suitcase

Screen Shot 2022-05-31 at 15 36 08

Screen Shot 2022-05-31 at 15 36 17

Screen Shot 2022-05-31 at 15 46 28

campsite

campsite MAP LINK

Screen Shot 2022-05-31 at 15 36 25

Screen Shot 2022-05-31 at 15 37 11

Screen Shot 2022-05-31 at 15 46 34

water

water

Screen Shot 2022-05-31 at 15 37 21

Screen Shot 2022-05-31 at 15 37 32

Screen Shot 2022-05-31 at 15 46 41

gift

gift

Screen Shot 2022-05-31 at 15 37 43

Screen Shot 2022-05-31 at 15 37 52

Screen Shot 2022-05-31 at 15 46 47

waterfall

waterfall

Screen Shot 2022-05-31 at 15 38 00

Screen Shot 2022-05-31 at 15 38 06

Screen Shot 2022-05-31 at 15 46 52

toilet

toilet MAP LINK

Screen Shot 2022-05-31 at 15 38 15

Screen Shot 2022-05-31 at 15 38 23

Screen Shot 2022-05-31 at 15 46 57

city

city

Screen Shot 2022-05-31 at 15 38 31

Screen Shot 2022-05-31 at 15 38 38

Screen Shot 2022-05-31 at 15 47 01

cross

cross

Screen Shot 2022-05-31 at 15 38 46

Screen Shot 2022-05-31 at 15 38 56

Screen Shot 2022-05-31 at 15 47 06

car-rental

car-rental MAP LINK

Screen Shot 2022-05-31 at 15 39 06

Screen Shot 2022-05-31 at 15 39 21

Screen Shot 2022-05-31 at 15 47 11

car-repair

car-repair MAP LINK

Screen Shot 2022-05-31 at 15 39 31

Screen Shot 2022-05-31 at 15 39 41

Screen Shot 2022-05-31 at 15 47 16

religious-muslim

religious-muslim

Screen Shot 2022-05-31 at 15 39 48

Screen Shot 2022-05-31 at 15 39 56

Screen Shot 2022-05-31 at 15 47 22

bowling-alley

bowling-alley

Screen Shot 2022-05-31 at 15 40 23

Screen Shot 2022-05-31 at 15 40 31

Screen Shot 2022-05-31 at 15 47 29

amusement-park

amusement-park MAP LINK

Screen Shot 2022-05-31 at 15 40 39

Screen Shot 2022-05-31 at 15 40 46

Screen Shot 2022-05-31 at 15 47 35

shelter

shelter

Screen Shot 2022-05-31 at 15 40 56

Screen Shot 2022-05-31 at 15 41 03

Screen Shot 2022-05-31 at 15 47 41

basketball

basketball MAP LINK

Screen Shot 2022-05-31 at 15 41 14

Screen Shot 2022-05-31 at 15 41 21

Screen Shot 2022-05-31 at 15 47 49

ferry-JP

ferry-JP

Screen Shot 2022-05-31 at 15 41 29

Screen Shot 2022-05-31 at 15 41 37

Screen Shot 2022-05-31 at 15 48 03

skateboard

skateboard

Screen Shot 2022-05-31 at 15 41 44

Screen Shot 2022-05-31 at 15 41 53

Screen Shot 2022-05-31 at 15 48 08

optician

optician MAP LINK

Screen Shot 2022-05-31 at 15 42 01

Screen Shot 2022-05-31 at 15 42 09

Screen Shot 2022-05-31 at 15 48 13

hot-spring

hot-spring

Screen Shot 2022-05-31 at 15 42 17

Screen Shot 2022-05-31 at 15 42 26

Screen Shot 2022-05-31 at 15 48 17

teahouse

teahouse

Screen Shot 2022-05-31 at 15 42 37

Screen Shot 2022-05-31 at 15 42 44

Screen Shot 2022-05-31 at 15 48 23

village

village

Screen Shot 2022-05-31 at 15 42 52

Screen Shot 2022-05-31 at 15 43 02

Screen Shot 2022-05-31 at 19 53 37

@Udobnyj
Copy link
Contributor

Udobnyj commented Jun 22, 2022

We discussed and decided to open a PR for this task. it will be easier to compare the changes in that way.

@Udobnyj Udobnyj mentioned this issue Jun 23, 2022
Merged
@Udobnyj Udobnyj closed this as completed Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Udobnyj Udobnyj

Labels
p2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Udobnyj @willymaps @melanieimfeld