Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Center icons #564

Closed
willymaps opened this issue Apr 20, 2022 · 2 comments
Closed

Center icons #564

willymaps opened this issue Apr 20, 2022 · 2 comments
Assignees

Comments

@willymaps
Copy link
Contributor

Icon Request

When placing maki icons inside of a background shape, icons that aren't centered vertically/horizontally appear too close to the background shape padding.

image

Icons that stand out are skiing, village, barrier, fence, and bridge.

@willymaps
Copy link
Contributor Author

slaughterhouse is likely the most problematic and has been discussed 1, 2

@Udobnyj
Copy link
Contributor

Udobnyj commented Apr 26, 2022

I checked all of the Maki icons. And choose 46 to change.

Screen Shot 2022-04-26 at 13 45 43

I moved them inside their 15px artboards. There is a changing comparing gif.
maki centered

Сheck please all my changes in the Figma file
https://www.figma.com/file/Ogqi7HpbVlr8yGw3ZrYL3g/Maki?node-id=319%3A1012

For six of them, I moved not accurate 1 pixel. but 0.5 pixel
I know we are trying to keep them in the grid, but TBH, many of them are already not so hard connected to the pixel grid. Maybe we can skip it? What do you think? Because they are looking way better moved that way.

Screen Shot 2022-04-26 at 14 02 13

And I have one more creepy one with no ability to move it because it filled the whole artboard.
Screen Shot 2022-04-26 at 13 45 50

@Udobnyj Udobnyj self-assigned this May 17, 2022
This was referenced May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants